Skip to content

Decode HTML entities by default on node #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remarkablemark merged 1 commit into from
Jan 26, 2017
Merged

Decode HTML entities by default on node #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
var domToReact = require('./lib/dom-to-react');
var htmlToDOM = require('html-dom-parser');

// decode HTML entities by default for `htmlparser2`
var domParserOptions = { decodeEntities: true };

/**
* Convert HTML string to React elements.
*
Expand All @@ -18,7 +21,7 @@ function HTMLReactParser(html, options) {
if (typeof html !== 'string') {
throw new TypeError('First argument must be a string');
}
return domToReact(htmlToDOM(html), options);
return domToReact(htmlToDOM(html, domParserOptions), options);
}

/**
Expand Down
7 changes: 7 additions & 0 deletions test/html-to-react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,13 @@ describe('html-to-react', function() {
assert.equal(render(reactElement), svg);
});

it('decodes HTML entities', function() {
var encodedEntities = 'asdf & ÿ ü '';
var decodedEntities = 'asdf & ÿ ü \'';
var reactElement = Parser('<i>' + encodedEntities + '</i>');
assert.equal(reactElement.props.children, decodedEntities);
});

});

/**
Expand Down