Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add imageExtensions option #5

Merged
merged 5 commits into from
Nov 4, 2021
Merged

Add imageExtensions option #5

merged 5 commits into from
Nov 4, 2021

Conversation

ChristianMurphy
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Makes the extensions supported by remark-images configurable through options.
In addition this adds webp and avif to extensions recognized as images by default.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Oct 30, 2021
@ChristianMurphy ChristianMurphy mentioned this pull request Oct 30, 2021
Merged
5 tasks
@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Oct 30, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
wooorm
wooorm reviewed Oct 31, 2021
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
readme.md Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@ChristianMurphy ChristianMurphy force-pushed the feature/configure-image-extensions branch from 482acf3 to 4c9d59a Compare October 31, 2021 14:27
wooorm
wooorm reviewed Oct 31, 2021
View reviewed changes
readme.md Show resolved Hide resolved
@wooorm
Copy link
Member

wooorm commented Nov 3, 2021

@ChristianMurphy Can you rebase?

ChristianMurphy and others added 5 commits November 3, 2021 11:24
@ChristianMurphy
feat(api): add support for configurable image extensions
c02de98
@ChristianMurphy
test(api): add test cases for default and custom extensions
280a41b
@ChristianMurphy
test(api): ensure defaultImageExtensions are provided
146bc49
@ChristianMurphy
test(api): ensure removing a default extension is supported
4d132ac
@ChristianMurphy @wooorm
refactor: code review feedback
b924c13 
* include `void[]` as an options type
* create constant regex ahead of time
* document `defaultImageExtensions` in API section of readme
* add description to jsdoc/tsdoc options type

Co-authored-by: Titus Wormer <tituswormer@gmail.com>
@ChristianMurphy ChristianMurphy force-pushed the feature/configure-image-extensions branch from f3815f8 to b924c13 Compare November 3, 2021 19:15
@ChristianMurphy
Copy link
Member Author

rebased

@wooorm wooorm changed the title feat(api): add support for configurable image extensions Add imageExtensions option Nov 4, 2021
@wooorm wooorm merged commit 590842a into remarkjs:main Nov 4, 2021
@wooorm wooorm added the 💪 phase/solved Post is done label Nov 4, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Nov 4, 2021
@wooorm
Copy link
Member

wooorm commented Nov 4, 2021

released!

@ChristianMurphy ChristianMurphy deleted the feature/configure-image-extensions branch November 4, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface ☂️ area/types This affects typings 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristianMurphy @codecov-commenter @wooorm