Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add imageExtensions option #5

Merged
merged 5 commits into from
Nov 4, 2021
Merged

Add imageExtensions option #5

merged 5 commits into from
Nov 4, 2021

Commits on Nov 3, 2021

  1. feat(api): add support for configurable image extensions

    @ChristianMurphy
    ChristianMurphy committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    c02de98 View commit details
    Browse the repository at this point in the history

  2. test(api): add test cases for default and custom extensions

    @ChristianMurphy
    ChristianMurphy committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    280a41b View commit details
    Browse the repository at this point in the history

  3. test(api): ensure defaultImageExtensions are provided

    @ChristianMurphy
    ChristianMurphy committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    146bc49 View commit details
    Browse the repository at this point in the history

  4. test(api): ensure removing a default extension is supported

    @ChristianMurphy
    ChristianMurphy committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    4d132ac View commit details
    Browse the repository at this point in the history

  5. refactor: code review feedback 

    * include `void[]` as an options type
* create constant regex ahead of time
* document `defaultImageExtensions` in API section of readme
* add description to jsdoc/tsdoc options type

Co-authored-by: Titus Wormer <tituswormer@gmail.com>
    @ChristianMurphy @wooorm
    ChristianMurphy and wooorm committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    b924c13 View commit details
    Browse the repository at this point in the history