Onelogin authentication backend #1018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejholmes
commented
Nov 1, 2016
| User *empire.User | ||
|
|
||
| // When this Session will expire. The zero value means no expiration. | ||
| ExpiresAt *time.Time |
There was a problem hiding this comment.
This allows us to propagate the SessionNotOnOrAfter assertion down, and ensures that access tokens created expire with the SAML session.
|
I checked this out again on friday. Apparently still broken on OneLogin's side. /sigh I bugged their support again to see what they're doing about it. |
|
OneLogin support finally got a response from their engineering team on this and got back to me. They say that support for Duo devices in the API is unsupported (despite having docs referencing Duo devices). So, I'm going to close this for now. |
|
Why is there no annoyed emoji for this? Grrr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compliments the SAML authentication backend added in #1017, with a Onelogin extension using the Generate SAML assertion API of Onelogin. This allows users to use
emp loginto perform SAML authentication, instead of using the browser flow.With that said, this currently doesn't work for me because Duo devices are apparently broken in the Onelogin API. Onelogin has verified that it is broken, but I've yet to hear back from them one what they're doing to fix it.