Maximum session durations #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejholmes
force-pushed
the
session-expiration
branch
from
837bf58
to
1d181dc
Compare
phobologic
approved these changes
Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extraction of the session expiration pieces from #1018. #1018 can't be merged yet because of bugs in the OneLogin API, but being able to set a maximum session duration would still be incredibly valuable for additional security.
This adds a new
EMPIRE_SERVER_SESSION_EXPIRATIONenv var, that can be set to something like24hto ensure that users need to re-authenticate periodically, thus ensuring that API keys are rotated frequently. By default, and for backwards compatibility, sessions and access tokens will not expire.