disable compression for RSC responses for now #14381
Conversation
🦋 Changeset detectedLatest commit: 60b1165 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/react-router-serve/cli.ts
Outdated
| compression(), | ||
| express.static(build.assetsBuildDirectory), | ||
| ); | ||
| app.use(compression(), express.static("public", { maxAge: "1h" })); |
There was a problem hiding this comment.
Doesn't this still apply compression to all incoming requests because it doesn't have a path?
|
|
||
| let app = express(); | ||
| app.disable("x-powered-by"); | ||
| app.use(compression()); |
There was a problem hiding this comment.
Would it be easier/less risk of impacting non-RSC use cases to just disable it completely for RSC framework mode for now because it's unstable?
if (!isRSCServerBuild(build)) {
app.use(compression());
}I assume we'll want to turn it back on before stabilizing so then we can just remove the if and not unwind these other changes?
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
2 participants
No description provided.