Skip to content

disable compression for RSC responses for now #14381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

disable compression for RSC responses for now #14381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
667adc8
disable compression for RSC responses for now
jacob-ebey Sep 23, 2025
60b1165
Simplify approach to just on or off completely
brophdawg11 Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nice-apples-burn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@react-router/serve": patch
---

disable compression for RSC responses for now
6 changes: 5 additions & 1 deletion packages/react-router-serve/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,11 @@ async function run() {

let app = express();
app.disable("x-powered-by");
app.use(compression());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be easier/less risk of impacting non-RSC use cases to just disable it completely for RSC framework mode for now because it's unstable?

  if (!isRSCServerBuild(build)) {
    app.use(compression());
  }

I assume we'll want to turn it back on before stabilizing so then we can just remove the if and not unwind these other changes?


if (!isRSCServerBuild(build)) {
app.use(compression());
}

app.use(
path.posix.join(build.publicPath, "assets"),
express.static(path.join(build.assetsBuildDirectory, "assets"), {
Expand Down