Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix-dev): add option to remove typescript types during project creation #2317

Merged
merged 28 commits into from
Mar 22, 2022
Merged

feat(remix-dev): add option to remove typescript types during project creation #2317

merged 28 commits into from
Mar 22, 2022

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Mar 15, 2022 •
edited
Loading

Closes: REM-830

  • Docs
  • Tests

@mcansh mcansh changed the title feat: strip ts types feat(remix-dev): add option to remove typescript types during project creation Mar 15, 2022
mjackson
mjackson reviewed Mar 16, 2022
View reviewed changes
packages/remix-dev/create.ts Outdated Show resolved Hide resolved
packages/remix-dev/__tests__/cli-test.ts Outdated Show resolved Hide resolved
MichaelDeBoey
MichaelDeBoey reviewed Mar 21, 2022
View reviewed changes
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcansh It seems like something went wrong with the examples 🤔

@mcansh
Copy link
Collaborator Author

mcansh commented Mar 21, 2022

@mcansh It seems like something went wrong with the examples 🤔

I tried to just copy the latest dev ones over, I'll reset and cherry-pick over the commits that actually matter in a sec

@mcansh
chore: use name as given
eda5a74 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
test: add test for converting a project to javascript
82632de 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit dfedcf5)
@mcansh
chore: default useTypeScript to true
228dc0c 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit fed4544)
@mcansh
update extension used in test
9f292a2 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit 01cb390)
@mcansh
test: add globalSetup to remix-dev
d234472 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit 356b79f)
@mcansh
chore: import babel preset and plugin
0edbe5e 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit 450e37c)
@mcansh
chore: review changes
c62ae0a 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit 3c7e857)
@mcansh
test: add subfolder to tmp for each type of test
93aad02 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit e21ca66)
@mcansh
test: re-add test for file URL to a tarball on disk, and separate str…
49fb048 
…ipping ts test

Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit 75c9834)
@mcansh
test: update CLI output
022d86a 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit 5efcdbf)
@mcansh
fix: exclude typescript dep
8900894 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit b062770)
@mcansh
test: add template options for createFixture
481cbb1 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit 3cbd130)
@mcansh
fix: pass projectDir to babel
d33188c 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit bdda789)
@mcansh
chore: remove javascript templates
8d96140 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
feat: convert template to js
45a98da 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
test: update afterAll hook
1906eea 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
MichaelDeBoey
MichaelDeBoey requested changes Mar 21, 2022
View reviewed changes
templates/arc/package.json Outdated Show resolved Hide resolved
@mcansh
chore: update template names
9d72055 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
test: update opt out dep message
7be390a 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
test: update template URL until this PR is merged
4c84d25 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
test: update js conversion test
44a10ef 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
test: updated the url so i didnt have to skip it lol
db12a71 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
test: update beforeAll
704d8ad 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mjackson
mjackson requested changes Mar 22, 2022
View reviewed changes
Copy link
Member

@mjackson mjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nitpicks. Looking good overall though! So good to get rid of all those duplicate templates!

packages/remix-dev/__tests__/cli-test.ts Outdated Show resolved Hide resolved
packages/remix-dev/__tests__/cli-test.ts Outdated Show resolved Hide resolved
packages/remix-dev/cli/create.ts Outdated Show resolved Hide resolved
packages/remix-dev/cli/create.ts Outdated Show resolved Hide resolved
@mcansh
chore: code review
2145618 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
test: skip test instead of adding a todo
5b1e52a 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: emptyDir will create the dir if it doesnt exist
2cbbd26 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
Merge branch 'dev' into logan/ts-strip-types
2c6225c
mjackson
mjackson approved these changes Mar 22, 2022
View reviewed changes
integration/helpers/global-setup.ts Outdated Show resolved Hide resolved
@mcansh
chore: code review
dc179ea 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh merged commit b9e82e9 into dev Mar 22, 2022
@mcansh mcansh deleted the logan/ts-strip-types branch March 22, 2022 22:17
@MichaelDeBoey MichaelDeBoey mentioned this pull request Mar 23, 2022
Merged
@mcansh mcansh mentioned this pull request Mar 25, 2022
Merged
2 tasks
@MichaelDeBoey MichaelDeBoey mentioned this pull request Mar 28, 2022
Merged
@mcansh mcansh mentioned this pull request Mar 30, 2022
Merged
2 tasks
MichaelDeBoey pushed a commit that referenced this pull request May 3, 2022
@dogukanakkaya
docs(templates/express): fix README (#2441)
8eddc74 
* fix: server build path in gitignore and readme

* revert: express-ts since it has been removed pr #2317
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 10, 2022
@dogukanakkaya @aaronpowell
docs(templates/express): fix README (remix-run#2441)
f740311 
* fix: server build path in gitignore and readme

* revert: express-ts since it has been removed pr remix-run#2317
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 12, 2022
@dogukanakkaya @aaronpowell
docs(templates/express): fix README (remix-run#2441)
34dedde 
* fix: server build path in gitignore and readme

* revert: express-ts since it has been removed pr remix-run#2317
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 15, 2022
@dogukanakkaya @aaronpowell
docs(templates/express): fix README (remix-run#2441)
549c2ca 
* fix: server build path in gitignore and readme

* revert: express-ts since it has been removed pr remix-run#2317
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 16, 2022
@dogukanakkaya @aaronpowell
docs(templates/express): fix README (remix-run#2441)
1c4c95d 
* fix: server build path in gitignore and readme

* revert: express-ts since it has been removed pr remix-run#2317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjackson mjackson mjackson approved these changes

@MichaelDeBoey MichaelDeBoey Awaiting requested review from MichaelDeBoey

Assignees
No one assigned
Labels
CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcansh @mjackson @MichaelDeBoey