-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(templates/express): fix README
#2441
Merged
MichaelDeBoey
merged 3 commits into
remix-run:main
from
dogukanakkaya:fix/express/server_build_path
May 3, 2022
Merged
docs(templates/express): fix README
#2441
MichaelDeBoey
merged 3 commits into
remix-run:main
from
dogukanakkaya:fix/express/server_build_path
May 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogukanakkaya
changed the title
feat: fix server build path in gitignore and readme
fix: server build path in gitignore and readme
Mar 22, 2022
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
@dogukanakkaya Changes to |
@MichaelDeBoey done. |
MichaelDeBoey
changed the title
fix: server build path in gitignore and readme
fix(templates/express): fix server build path in Mar 28, 2022
.gitignore
& README
Let's wait for this to merge until we have a new release and #2317 is available in |
@dogukanakkaya Please rebase your branch onto latest |
MichaelDeBoey
added
the
needs-response
We need a response from the original author about this issue/PR
label
May 3, 2022
MichaelDeBoey
changed the title
fix(templates/express): fix server build path in
docs(templates/express): fix May 3, 2022
.gitignore
& README
README
MichaelDeBoey
removed
the
needs-response
We need a response from the original author about this issue/PR
label
May 3, 2022
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 10, 2022
* fix: server build path in gitignore and readme * revert: express-ts since it has been removed pr remix-run#2317
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 12, 2022
* fix: server build path in gitignore and readme * revert: express-ts since it has been removed pr remix-run#2317
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 15, 2022
* fix: server build path in gitignore and readme * revert: express-ts since it has been removed pr remix-run#2317
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 16, 2022
* fix: server build path in gitignore and readme * revert: express-ts since it has been removed pr remix-run#2317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Express Server build path is not in the server dir. It is in the root dir of the project.