Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(templates/express): fix README #2441

Merged
merged 3 commits into from
May 3, 2022
Merged

docs(templates/express): fix README #2441

merged 3 commits into from
May 3, 2022

Conversation

dogukanakkaya
Copy link
Contributor

Express Server build path is not in the server dir. It is in the root dir of the project.

@dogukanakkaya dogukanakkaya changed the title feat: fix server build path in gitignore and readme fix: server build path in gitignore and readme Mar 22, 2022
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 22, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey
Copy link
Member

@dogukanakkaya Changes to templates go on main branch.
Could you please rebase your branch latest main?

@dogukanakkaya dogukanakkaya changed the base branch from dev to main March 22, 2022 15:00
@dogukanakkaya dogukanakkaya changed the base branch from main to dev March 22, 2022 15:03
@dogukanakkaya dogukanakkaya changed the base branch from dev to main March 22, 2022 15:04
@dogukanakkaya
Copy link
Contributor Author

@MichaelDeBoey done.

@MichaelDeBoey MichaelDeBoey changed the title fix: server build path in gitignore and readme fix(templates/express): fix server build path in .gitignore & README Mar 28, 2022
@MichaelDeBoey
Copy link
Member

Let's wait for this to merge until we have a new release and #2317 is available in main

@MichaelDeBoey
Copy link
Member

@dogukanakkaya Please rebase your branch onto latest main & fix conflicts

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label May 3, 2022
@MichaelDeBoey MichaelDeBoey changed the title fix(templates/express): fix server build path in .gitignore & README docs(templates/express): fix README May 3, 2022
@MichaelDeBoey MichaelDeBoey removed the needs-response We need a response from the original author about this issue/PR label May 3, 2022
@MichaelDeBoey MichaelDeBoey merged commit 8eddc74 into remix-run:main May 3, 2022
@dogukanakkaya dogukanakkaya deleted the fix/express/server_build_path branch May 3, 2022 19:37
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 10, 2022
* fix: server build path in gitignore and readme

* revert: express-ts since it has been removed pr remix-run#2317
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 12, 2022
* fix: server build path in gitignore and readme

* revert: express-ts since it has been removed pr remix-run#2317
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 15, 2022
* fix: server build path in gitignore and readme

* revert: express-ts since it has been removed pr remix-run#2317
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 16, 2022
* fix: server build path in gitignore and readme

* revert: express-ts since it has been removed pr remix-run#2317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants