Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(jokes): Add missing highlight of updated lines #2395

Merged
merged 6 commits into from
Mar 20, 2022
Merged

docs(jokes): Add missing highlight of updated lines #2395

merged 6 commits into from
Mar 20, 2022

Conversation

dan-gamble
Copy link
Contributor

No description provided.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 19, 2022

Hi @dan-gamble,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 19, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@machour machour added the docs label Mar 19, 2022
machour
machour reviewed Mar 19, 2022
View reviewed changes
docs/tutorials/jokes.md Outdated Show resolved Hide resolved
@machour machour marked this pull request as draft March 19, 2022 12:25
@machour
Copy link
Collaborator

machour commented Mar 19, 2022

Hi @dan-gamble, converted the PR to draft since you're still making commits.
Let us know when you're finished 🙏🏼

@dan-gamble
Copy link
Contributor Author

Just things I noticed as I was working my way through the tutorial. I've finished that now so this is ready 😅

@dan-gamble dan-gamble marked this pull request as ready for review March 19, 2022 15:20
This was referenced Mar 20, 2022
Closed
Closed
@machour
Copy link
Collaborator

machour commented Mar 20, 2022

Thank you so much @dan-gamble 🙏🏼

@machour machour changed the title Add missing highlight of updated lines docs(jokes): Add missing highlight of updated lines Mar 20, 2022
@machour machour merged commit c7476df into remix-run:main Mar 20, 2022
@dan-gamble dan-gamble deleted the patch-1 branch March 20, 2022 12:13
F3n67u pushed a commit to F3n67u/remix that referenced this pull request Mar 21, 2022
@dan-gamble @F3n67u
docs(jokes): Add missing highlight of updated lines (remix-run#2395)
7d37494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machour machour machour approved these changes

Assignees
No one assigned
Labels
CLA Signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-gamble @machour