Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(jokes): Add missing highlight of updated lines #2395

Merged
merged 6 commits into from
Mar 20, 2022
Merged

docs(jokes): Add missing highlight of updated lines #2395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9299114
Add missing highlight of updated lines
dan-gamble Mar 19, 2022
e8dcc28
Update contributors.yml
dan-gamble Mar 19, 2022
ea016aa
Highlight rebuilt lines in root.tsx
dan-gamble Mar 19, 2022
a39fd4a
Update new.tsx CatchBoundary
dan-gamble Mar 19, 2022
39897da
Fix line highlight typo
dan-gamble Mar 19, 2022
20863ac
Correct line highlight
dan-gamble Mar 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
- cysp
- damiensedgwick
- danielweinmann
- dan-gamble
- davecalnan
- DavidHollins6
- denissb
Expand Down
6 changes: 3 additions & 3 deletions docs/tutorials/jokes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3407,7 +3407,7 @@ export async function createUserSession(

<summary>app/routes/jokes.tsx</summary>

```tsx filename=app/routes/jokes.tsx lines=[6,14,30,52-63]
```tsx filename=app/routes/jokes.tsx lines=[6,14,18-20,26,30,52-63]
import type { User } from "@prisma/client";
import type { LinksFunction, LoaderFunction } from "remix";
import { json, Link, Outlet, useLoaderData } from "remix";
Expand Down Expand Up @@ -3952,7 +3952,7 @@ Remember that the `app/root.tsx` module is responsible for rendering our `<html>

<summary>app/root.tsx</summary>

```tsx filename=app/root.tsx lines=[57-67]
```tsx filename=app/root.tsx lines=[27-47,49-55,57-67]
import type { LinksFunction } from "remix";
import { Links, LiveReload, Outlet } from "remix";

Expand Down Expand Up @@ -4352,7 +4352,7 @@ export function ErrorBoundary() {

<summary>app/routes/jokes/new.tsx</summary>

```tsx filename=app/routes/jokes/new.tsx lines=[6,16-24,156-167]
```tsx filename=app/routes/jokes/new.tsx lines=[6,16-24,164-175]
import type { ActionFunction, LoaderFunction } from "remix";
import {
useActionData,
Expand Down