Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix small typo in doc #2433

Closed
wants to merge 13 commits into from
Closed

fix small typo in doc #2433

wants to merge 13 commits into from

Conversation

TheRealAstoo
Copy link
Contributor

Hello 👋

This PR fixes a small typo in the DEVELOPMENT.md doc I went by. 😃

  • Docs
  • Tests

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 21, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@machour
Copy link
Collaborator

machour commented Mar 21, 2022

Hey @TheRealAstoo and thank you for taking the time to make this PR.
Would you mind changing its target to main instead of dev ? Documentation fixes should go directly to main 🙏🏼

@machour machour added needs-response We need a response from the original author about this issue/PR docs labels Mar 21, 2022
@MichaelDeBoey MichaelDeBoey changed the base branch from dev to main March 21, 2022 19:25
donavon and others added 13 commits March 21, 2022 20:25
Use remix-dev directly in create-remix (No need to use a shell to execute remix-dev)

Co-authored-by: Chance Strickland <hi@chance.dev>
remix-run#2342)

fix: load module after action submission if it's not a redirect
fix: when an action "catches", still load next data for next location to render nested boundaries and not be missing parent data
…rface (remix-run#2359)

* feat(@remix-run/server-runtime): define interface for remix server runtimes

* refactor(@remix-run/server-runtime): organize exports

group types that should be re-exported by each remix server runtime

* refactor(@remix-run/server-runtime): factories for crypto-dependent interface functions

* docs(@remix-run/server-runtime): rewrite readme to explain the "remix server runtime interface"

* refactor(@remix-run/node): conform to the remix server runtime interface

instead of relying on magic exports

* refactor(@remix-run/node): implement crypto-dependent interface functions

* feat(@remix-run/cloudflare): create new server runtime package for cloudflare

* refactor(@remix-run/cloudflare): implement crypto-dependent interface functions

* refactor(remix-deno): conform to the remix server runtime interface

* refactor(remix-deno): implement crypto-dependent interface functions

* refactor(@remix-run/architect): use `@remix-run/node` instead of `@remix-run/server-runtime`

* refactor(@remix-run/express): use `@remix-run/node` instead of `@remix-run/server-runtime`

* refactor(@remix-run/netlify): use `@remix-run/node` instead of `@remix-run/server-runtime`

* refactor(@remix-run/vercel): use `@remix-run/node` instead of `@remix-run/server-runtime`

* refactor(@remix-run/cloudflare-workers): use `@remix-run/cloudflare` instead of `@remix-run/server-runtime`

* refactor(@remix-run/cloudflare-pages): use `@remix-run/cloudflare` instead of `@remix-run/server-runtime`

* refactor(server-runtimes,adapters): remove unused `platform` arg from `createRequestHandler`
@MichaelDeBoey
Copy link
Member

@TheRealAstoo I tried to do it automatically with the GitHub UI, but seems like I did something wrong here 😓

git reset --hard main
git cherry-pick baa841d

@TheRealAstoo
Copy link
Contributor Author

Hey @TheRealAstoo and thank you for taking the time to make this PR. Would you mind changing its target to main instead of dev ? Documentation fixes should go directly to main 🙏🏼

Sure ! 😃

@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Mar 21, 2022
TheRealAstoo added a commit to TheRealAstoo/remix that referenced this pull request Mar 21, 2022
@TheRealAstoo TheRealAstoo mentioned this pull request Mar 21, 2022
2 tasks
@TheRealAstoo
Copy link
Contributor Author

Hey @TheRealAstoo and thank you for taking the time to make this PR. Would you mind changing its target to main instead of dev ? Documentation fixes should go directly to main 🙏🏼

I did it in #2436

@TheRealAstoo
Copy link
Contributor Author

If you approve the other, I'll close this one 👍

@MichaelDeBoey
Copy link
Member

Closing in favor of #2436

@MichaelDeBoey MichaelDeBoey added the duplicate This issue or pull request already exists label Mar 21, 2022
MichaelDeBoey pushed a commit to TheRealAstoo/remix that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed docs duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.