feat: add `@remix-run/azure-functions` package #2521

aaronpowell · 2022-03-28T06:27:39Z

This revives #246 and uplifts it to the current release of remix.

Docs
Tests

remix-cla-bot · 2022-03-28T06:27:42Z

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

remix-cla-bot · 2022-03-28T06:28:38Z

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

MichaelDeBoey · 2022-03-29T23:02:56Z

@aaronpowell Could you please rebase your branch on latest dev?

Also make sure to not use @remix-run/server-runtime directly, but use @remix-run/node instead in the adapters.
Check out #2359 to see how all other adapters have changed.

aaronpowell · 2022-03-29T23:26:56Z

@MichaelDeBoey yep, I'll clean up with a rebase shortly and refactor it to follow the patterns of the other adapters.

My first goal was just to get the build passing, then tidy up 😅

MichaelDeBoey · 2022-03-30T01:24:29Z

@aaronpowell I think some things went wrong with rebasing.

If you can't figure it out, you could do

git reset --hard dev
git cherry-pick [commit-sha]

You need to do git push --force in order to make the rebase complete.

aaronpowell · 2022-03-30T01:36:18Z

@MichaelDeBoey as yes, I see a few errors across the style and jest files.

It's a little difficult to do the cherry picking as there's 30 commits that need to be brought in on the HEAD for the rebase and they are from pre-remix 1.0 so they have some differences that can be difficult to manually merge. I can clean up those files on the HEAD now.

MichaelDeBoey

@aaronpowell Also make sure to add .eslintrc to the template and update the favicon to the new .ico instead of the old .png please

jest.config.js

packages/remix-azure-functions/server.ts

packages/remix-server-runtime/headers.ts

rollup.config.js

templates/azure-functions/.gitignore

packages/remix-azure-functions/package.json

templates/azure-functions/.eslintrc

packages/remix-azure-functions/__tests__/server-test.ts

packages/remix-azure-functions/server.ts

package.json

packages/remix-architect/package.json

packages/remix-server-runtime/package.json

packages/remix-vercel/package.json

rollup.config.js

templates/azure-functions/package.json

packages/remix-azure-functions/__tests__/server-test.ts

packages/remix-azure-functions/package.json

packages/remix-azure-functions/magicExports/remix.ts

MichaelDeBoey

Could you please also rebase onto latest dev & resolve conflicts?

docs/other-api/adapter.md

packages/remix-azure-functions/package.json

packages/remix-azure-functions/server.ts

aaronpowell · 2022-03-31T23:17:05Z

Could you please also rebase onto latest dev & resolve conflicts?

I'll get to a rebase today and hopefully not stuff up any of the merges this time

aaronpowell · 2022-04-01T00:32:38Z

Deployed using the template - https://agreeable-desert-0f0e5cc10.1.azurestaticapps.net/

MichaelDeBoey · 2022-04-01T01:37:12Z

@aaronpowell Could you please run the following to make sure we're not breaking yarn.lock with the rebases?

git checkout dev yarn.lock && yarn clean && yarn

aaronpowell · 2022-04-01T03:44:31Z

@aaronpowell Could you please run the following to make sure we're not breaking yarn.lock with the rebases?
git checkout dev yarn.lock && yarn clean && yarn

Doing my best on the older rebases were harder as they were quite out of date. The last commit I had forgot to run a yarn clean && yarn, it wasn't until I pushed the commit prior that I realised and fixed it up

MichaelDeBoey · 2022-05-03T17:40:55Z

@aaronpowell Please rebase your branch onto latest dev & resolve conflicts.

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>

Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Co-authored-by: Christian Köberl <derkoe@users.noreply.github.com>

derkoe · 2022-08-21T15:31:07Z

For all people not patient enough (like me): I have published the package here: https://www.npmjs.com/package/@derkoe/remix-azure-functions. (The build/code publishing this package is here: https://github.com/derkoe/remix-azure-functions)

mzaatar · 2022-09-20T03:20:43Z

could someone give us ETA on this one? We are keen to use it and the sample GitHub/npm package is not quite clear on how to use it.

MichaelDeBoey · 2022-09-20T08:58:25Z

@mzaatar The team will look into this PR whenever they have the time for it, but new adapters are not high on the priority list for the moment.

derkoe · 2022-09-20T14:20:16Z

@mzaatar I have a working demo here https://github.com/derkoe/remix-azure-functions-demo using the npm package @derkoe/remix-azure-functions.

templates/azure-functions/app/entry.client.tsx

MichaelDeBoey

It seems like we're also missing remix.env.d.ts in the template 🤔

templates/azure-functions/public/staticwebapp.config.json

MichaelDeBoey · 2022-09-29T22:44:39Z

packages/remix-azure-functions/magicExports/remix.ts

@@ -0,0 +1,9 @@
+/* eslint-disable import/no-extraneous-dependencies */


We now have a new way of handling magicExports.
Please add the magic exports in getMagicExports function of the root's rollup.utils.js

packages/remix-azure-functions/package.json

templates/azure-functions/app/entry.server.tsx

templates/azure-functions/package.json

MichaelDeBoey · 2022-09-29T23:17:11Z

templates/azure-functions/package.json

+    "@azure/static-web-apps-cli": "^0.8.3",
+    "@remix-run/dev": "*",
+    "@remix-run/eslint-config": "*",
+    "@remix-run/serve": "*",


Not needed I think, as we already have @azure/functions?

Suggested change

"@remix-run/serve": "*",

The package @azure/functions isn't a hosting package, it's just a types package.

Then this one should go into dependencies I think?

templates/azure-functions/package.json

templates/azure-functions/tsconfig.json

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>

chaance · 2023-01-23T23:15:37Z

We aren't looking to add new adapter packages for the time being, though we encourage hosts to maintain and promote them! If anything changes on that front we will reopen this.

arunmmanoharan · 2023-07-16T20:48:49Z

@aaronpowell If you are planning to update this, could this be done using functions v4?

aaronpowell · 2023-07-16T23:48:04Z

@aaronpowell If you are planning to update this, could this be done using functions v4?

No, I don't have any intents to update this PR.

remix-cla-bot bot added the CLA Signed label Mar 28, 2022

aaronpowell changed the title ~~Azure Functions hosting for Remix~~ feat(remix-azure): azure functions hosting Mar 28, 2022

aaronpowell force-pushed the azure-functions-host branch from 2e6ce40 to 9537e52 Compare March 29, 2022 06:21

MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Mar 29, 2022

MichaelDeBoey changed the title ~~feat(remix-azure): azure functions hosting~~ feat: add remix-azure-functions package Mar 29, 2022

github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Mar 29, 2022

aaronpowell force-pushed the azure-functions-host branch from dff4cfd to a8db21c Compare March 30, 2022 01:16

MichaelDeBoey requested changes Mar 30, 2022

View reviewed changes

aaronpowell marked this pull request as ready for review March 30, 2022 05:17

aaronpowell requested a review from MichaelDeBoey March 30, 2022 05:17

MichaelDeBoey requested changes Mar 30, 2022

View reviewed changes

packages/remix-azure-functions/magicExports/remix.ts Show resolved Hide resolved

MichaelDeBoey requested changes Mar 31, 2022

View reviewed changes

aaronpowell force-pushed the azure-functions-host branch from 62a6f22 to aa8dab7 Compare March 31, 2022 23:21

aaronpowell requested a review from MichaelDeBoey April 1, 2022 00:32

aaronpowell force-pushed the azure-functions-host branch from 0d07670 to 33f724a Compare April 1, 2022 03:40

MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label May 3, 2022

aaronpowell force-pushed the azure-functions-host branch from 33f724a to b807f4b Compare May 3, 2022 23:24

aaronpowell and others added 12 commits August 20, 2022 13:19

test: fixing the azure functions tests

4fa2072

test: adding missing tests

ee10de7

Apply suggestions from code review

adb6781

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>

chore: tidying up docs for azure functions

266d4b2

chore: alphabetising the order

8373aab

fix: missing jest setup

86edd6b

chore: update yarn.lock

408cdea

Apply suggestions from code review

cb539af

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>

chore(remix-azure-functions): run sort-package-json

58be825

chore(remix-azure-functions): update dependencies

63783db

chore(remix-azure-functions): add engines field to package.json

a2ffdf0

Apply suggestions from code review

8e94a44

Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Co-authored-by: Christian Köberl <derkoe@users.noreply.github.com>

MichaelDeBoey force-pushed the azure-functions-host branch from 253e537 to 8e94a44 Compare August 20, 2022 11:24

MichaelDeBoey added the NEW API label Sep 5, 2022

mcansh requested changes Sep 29, 2022

View reviewed changes

templates/azure-functions/app/entry.client.tsx Outdated Show resolved Hide resolved

MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Sep 29, 2022

aaronpowell commented Sep 29, 2022

View reviewed changes

templates/azure-functions/app/entry.client.tsx Outdated Show resolved Hide resolved

Update templates/azure-functions/app/entry.client.tsx

ecaaeef

MichaelDeBoey requested changes Sep 29, 2022

View reviewed changes

Apply suggestions from code review

f9b65ff

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>

github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Nov 3, 2022

derkoe mentioned this pull request Nov 8, 2022

Azure Static Webapps / Functions Adaptor QwikDev/qwik#2053

Closed

chaance closed this Jan 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `@remix-run/azure-functions` package #2521

feat: add `@remix-run/azure-functions` package #2521

aaronpowell commented Mar 28, 2022 •

edited

Loading

remix-cla-bot bot commented Mar 28, 2022

remix-cla-bot bot commented Mar 28, 2022

MichaelDeBoey commented Mar 29, 2022

aaronpowell commented Mar 29, 2022

MichaelDeBoey commented Mar 30, 2022

aaronpowell commented Mar 30, 2022

MichaelDeBoey left a comment

MichaelDeBoey left a comment

aaronpowell commented Mar 31, 2022

aaronpowell commented Apr 1, 2022

MichaelDeBoey commented Apr 1, 2022

aaronpowell commented Apr 1, 2022

MichaelDeBoey commented May 3, 2022

derkoe commented Aug 21, 2022

mzaatar commented Sep 20, 2022

MichaelDeBoey commented Sep 20, 2022

derkoe commented Sep 20, 2022

MichaelDeBoey left a comment

MichaelDeBoey Sep 29, 2022

MichaelDeBoey Sep 29, 2022

aaronpowell Sep 30, 2022

MichaelDeBoey Sep 30, 2022

chaance commented Jan 23, 2023

arunmmanoharan commented Jul 16, 2023

aaronpowell commented Jul 16, 2023

		@@ -0,0 +1,9 @@
		/* eslint-disable import/no-extraneous-dependencies */

feat: add @remix-run/azure-functions package #2521

feat: add @remix-run/azure-functions package #2521

Conversation

aaronpowell commented Mar 28, 2022 • edited Loading

remix-cla-bot bot commented Mar 28, 2022

remix-cla-bot bot commented Mar 28, 2022

MichaelDeBoey commented Mar 29, 2022

aaronpowell commented Mar 29, 2022

MichaelDeBoey commented Mar 30, 2022

aaronpowell commented Mar 30, 2022

MichaelDeBoey left a comment

Choose a reason for hiding this comment

MichaelDeBoey left a comment

Choose a reason for hiding this comment

aaronpowell commented Mar 31, 2022

aaronpowell commented Apr 1, 2022

MichaelDeBoey commented Apr 1, 2022

aaronpowell commented Apr 1, 2022

MichaelDeBoey commented May 3, 2022

derkoe commented Aug 21, 2022

mzaatar commented Sep 20, 2022

MichaelDeBoey commented Sep 20, 2022

derkoe commented Sep 20, 2022

MichaelDeBoey left a comment

Choose a reason for hiding this comment

MichaelDeBoey Sep 29, 2022

Choose a reason for hiding this comment

MichaelDeBoey Sep 29, 2022

Choose a reason for hiding this comment

aaronpowell Sep 30, 2022

Choose a reason for hiding this comment

MichaelDeBoey Sep 30, 2022

Choose a reason for hiding this comment

chaance commented Jan 23, 2023

arunmmanoharan commented Jul 16, 2023

aaronpowell commented Jul 16, 2023

feat: add `@remix-run/azure-functions` package #2521

feat: add `@remix-run/azure-functions` package #2521

aaronpowell commented Mar 28, 2022 •

edited

Loading