feat(remix-node): add getFilePath& remove methods to NodeOnDiskFile

[cstrnt]

Closes: #3021

• Docs
• Tests

Testing Strategy:

• Added a test script in the remix-node package (remix-node tests never ran before)
• Added a simple unit test for the createFileUploadHandler function

[cstrnt]

@kentcdodds @ryanflorence @mjackson any chance you could take a look at this at some time?

[machour]

@cstrnt can you fix conflicts? That would help for the review

[cstrnt]

@machour sure thing, PR sat around for some time lol

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[MichaelDeBoey]

@cstrnt It seems like something went wrong when rebasing, could you please have a look?

[cstrnt]

@MichaelDeBoey I'm lost in rebase hell lol

[cstrnt]

The one failing test doesn't correlate to my code at all. Is it known to be a flaky one?

[kentcdodds]

Can you help me understand what the use case for this change is?

[machour]

@kentcdodds from the related discussion #3021

I'm currently fiddling around with Remix and while using unstable_createFileUploadHandler I've noticed that the filePath property on a NodeOnDiskFile is private. I don't think that this is really useful because I want to do some cleanup after using the file.

If it's better to keep the filePath property private, I think it would be nice to add a function called remove or cleanup that unlinks the file in the filesystem.

[kentcdodds]

Got it. I'll put this on @mjackson's plate 👍

[cstrnt]

@kentcdodds @mjackson small reminder 🤔

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5efef9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[kentcdodds]

Sorry, we've been very busy with other priorities. We'll get to this eventually. Thank you for your patience.

[cstrnt]

I’m deeply sorry, but I don’t feel like supporting a project led by such toxic lead maintainers