Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix-node): add getFilePath& remove methods to NodeOnDiskFile #4408

Merged
merged 5 commits into from
Jan 21, 2023
Merged

feat(remix-node): add getFilePath& remove methods to NodeOnDiskFile #4408

merged 5 commits into from
Jan 21, 2023

Conversation

julienmonnard
Copy link
Contributor

Closes: #3021

  • Docs
  • Tests

Testing Strategy:

One unit test for each new function, added in the remix-node package.

This is basically the same PR as #3034, but it got closed by its author before being merged. I believe this is a useful feature and would very much like to see it added.

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: fe8718c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/node Minor
@remix-run/architect Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/testing Minor
@remix-run/vercel Minor
@remix-run/serve Minor
@remix-run/dev Minor
create-remix Minor
remix Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/react Minor
@remix-run/server-runtime Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 23, 2022

Hi @julienmonnard,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 23, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@machour machour changed the title feat(node): add new methods to NodeOnDiskFile class feat(remix-node): add new methods to NodeOnDiskFile class Oct 24, 2022
@machour machour changed the title feat(remix-node): add new methods to NodeOnDiskFile class feat(remix-node): add remove() and getFilePath() to NodeOnDiskFile Oct 24, 2022
machour
machour approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@machour machour left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci Julien for picking up this! 🙌

Just a small update to the changeset and we should be good to go.

.changeset/flat-cobras-beam.md Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey changed the title feat(remix-node): add remove() and getFilePath() to NodeOnDiskFile feat(remix-node): add getFilePath& remove methods to NodeOnDiskFile Oct 27, 2022
MichaelDeBoey
MichaelDeBoey requested changes Oct 27, 2022
View reviewed changes
.changeset/flat-cobras-beam.md Outdated Show resolved Hide resolved
@julienmonnard
Copy link
Contributor Author

Is there something more that should be done for this to be able to make it in one of the next releases?
I guess with the whole react-router/remix stuff happening it was quite tricky, but now that 1.10 wraps it up and has landed, maybe there could be a little slot for this one :)

@mcansh mcansh merged commit c08f30f into remix-run:dev Jan 21, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-c08f30f-20230122 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

andrelandgraf pushed a commit to andrelandgraf/remix that referenced this pull request Jan 22, 2023
@julienmonnard @andrelandgraf
feat(remix-node): add getFilePath& remove methods to `NodeOnDiskF…
ceceb26 
…ile` (remix-run#4408)

* feat(node): add new methods to NodeOnDiskFile class

* chore: add name to contributors for CLA signature

* added changeset

* small changeset rewording

* reference the class instead of the file in changeset
@mcansh mcansh mentioned this pull request Jan 24, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcansh mcansh mcansh approved these changes

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@machour machour machour approved these changes

@mjackson mjackson Awaiting requested review from mjackson

@brophdawg11 brophdawg11 Awaiting requested review from brophdawg11

Assignees
No one assigned
Labels
CLA Signed NEW API runtime:node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julienmonnard @machour @MichaelDeBoey @mcansh