Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix playground creation #3643

Closed
wants to merge 12 commits into from
Closed

fix: fix playground creation #3643

wants to merge 12 commits into from

Conversation

federicoestevez
Copy link
Contributor

@federicoestevez federicoestevez commented Jul 2, 2022

Creating an application from the yarn playground:new command is currently not working, it is failing due to this error:

Running Remix Init...
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module '/workspaces/remix/playground/playground-1656781242957/node_modules/@remix-run/dev/cli'
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v17.6.0
node:internal/errors:844
  const err = new Error(message);
              ^

Error: Command failed: node ./node_modules/@remix-run/dev/cli init
    at checkExecSyncError (node:child_process:828:11)
    at execSync (node:child_process:899:15)
    at createNewProject (/workspaces/remix/scripts/playground/new.js:57:5) {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 14816,
  stdout: null,
  stderr: null
}

Node.js v17.6.0
error Command failed with exit code 1.

It seems to have stopped working since #3540

Closes: #

  • Docs
  • Tests

Testing Strategy:

yarn playground:new
...
Setup is complete. You're now ready to rock and roll 🤘

remix-cla-bot bot and others added 9 commits June 28, 2022 22:33
We already use `actions/setup-node@v3` which has equivalent caching
functionality that isn't broken for yarn+windows (or yarn 2+ across the
board). So just use that wherever possible. In addition to fixing builds,
this has the added benefit of slightly speeding them up, since we won't
double-cache things (in some cases we had both caches enabled).

For context, see bahmutov/npm-install#146, in
particular [this comment](bahmutov/npm-install#146 (comment)) and linked test output.
* fix: correcting broken link to routing guide on api/conventions page

* Update contributors.yml
* docs(api/conventions): fix a typo

* sign CLA
…ing Yarn (#3595)

* fix: dev:*

* chore: sign CLA

* chore: single-quote

* fix: think of the Windows users
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 2, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Collaborator

@mcansh mcansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@mcansh mcansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change your PR to point to dev instead of main?

@federicoestevez federicoestevez changed the base branch from main to dev July 2, 2022 19:19
Federico Estévez and others added 2 commits July 2, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants