-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix-react): add timeout
prop to LiveReload
component
#4036
feat(remix-react): add timeout
prop to LiveReload
component
#4036
Conversation
🦋 Changeset detectedLatest commit: c550099 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @joelazar, thank you for your submission (and sorry for the delay!) Can you target |
a63e335
to
47db8a3
Compare
Ah, sorry 🤦 , I've changed the target to |
a82cb1c
to
cd0d54f
Compare
timeout
prop to LiveReload
component
1e5ff64
to
40d50f0
Compare
2f58c29
to
040b509
Compare
Thanks @joelazar for the good work! 🙏 |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
LiveReload
component's reconnect attempt was hard coded to 1 sec. However, this breaks the feature if the page which attempts to be loaded has a loader that takes more than 1 sec to load (which communicates with 🐌 3rd-party APIs 😢). In that case, theLiveReload
component gets into an infinite loop.This change allows the consumer to configure the timeout manually.
Also you could even argue that the default timeout limit should be increased too.
Closes: #