Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-react): add timeout prop to LiveReload component #4036

Merged

Conversation

joelazar
Copy link
Contributor

@joelazar joelazar commented Aug 22, 2022

LiveReload component's reconnect attempt was hard coded to 1 sec. However, this breaks the feature if the page which attempts to be loaded has a loader that takes more than 1 sec to load (which communicates with 🐌 3rd-party APIs 😢). In that case, the LiveReload component gets into an infinite loop.

This change allows the consumer to configure the timeout manually.

Also you could even argue that the default timeout limit should be increased too.

Closes: #

  • Docs
  • Tests

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2022

🦋 Changeset detected

Latest commit: c550099

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@machour
Copy link
Collaborator

machour commented Sep 2, 2022

Hi @joelazar, thank you for your submission (and sorry for the delay!)

Can you target dev instead of main as per our contributing guide requirement?

@machour machour added the needs-response We need a response from the original author about this issue/PR label Sep 2, 2022
@machour machour changed the title configure timeout for livereload component feat(remix-react): Add timeout prop for <LiveReload /> component Sep 2, 2022
@machour machour added enhancement New feature or request renderer:react labels Sep 2, 2022
@joelazar joelazar changed the base branch from main to dev September 3, 2022 09:40
@joelazar joelazar changed the base branch from dev to main September 3, 2022 09:40
@joelazar joelazar force-pushed the feature/configure-timeout-for-livereload branch from a63e335 to 47db8a3 Compare September 3, 2022 09:47
@joelazar joelazar changed the base branch from main to dev September 3, 2022 09:47
@joelazar
Copy link
Contributor Author

joelazar commented Sep 3, 2022

Hi @joelazar, thank you for your submission (and sorry for the delay!)

Can you target dev instead of main as per our contributing guide requirement?

Ah, sorry 🤦 , I've changed the target to dev now.

@machour machour removed the needs-response We need a response from the original author about this issue/PR label Sep 3, 2022
@machour machour added the NEW API label Sep 5, 2022
@joelazar joelazar force-pushed the feature/configure-timeout-for-livereload branch from a82cb1c to cd0d54f Compare October 19, 2022 12:45
@joelazar joelazar closed this Oct 22, 2022
@joelazar joelazar reopened this Oct 22, 2022
@MichaelDeBoey MichaelDeBoey changed the title feat(remix-react): Add timeout prop for <LiveReload /> component feat(remix-react): add timeout prop to LiveReload component Jan 2, 2023
@pcattori pcattori force-pushed the feature/configure-timeout-for-livereload branch from 1e5ff64 to 40d50f0 Compare January 23, 2023 20:42
@pcattori pcattori force-pushed the feature/configure-timeout-for-livereload branch from 2f58c29 to 040b509 Compare January 23, 2023 20:46
@pcattori
Copy link
Contributor

Thanks @joelazar for the good work! 🙏

@pcattori pcattori merged commit ec3f3aa into remix-run:dev Jan 23, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-8346ace-20230124 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants