feat(remix-dev): add warning when `future.v2_routeConvention` is not enabled #5606

mcansh · 2023-02-28T20:58:54Z

~~for some reason adding the warning is causing the HMR tests to fail 🤔 https://github.com/remix-run/remix/actions/runs/4317024896/jobs/7533572210~~

edit: it was checking stderr length and the warning goes to stderr 🤦‍♂️

Closes: #

Docs
Tests

Testing Strategy:

changeset-bot · 2023-02-28T20:58:57Z

🦋 Changeset detected

Latest commit: 47a9ace

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
remix	Patch
@remix-run/dev	Patch
create-remix	Patch
@remix-run/css-bundle	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/deno	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/netlify	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/serve	Patch
@remix-run/server-runtime	Patch
@remix-run/testing	Patch
@remix-run/vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

… enabled Signed-off-by: Logan McAnsh <logan@mcan.sh> chore: update warning test: update test to include v2_routeConvention error message Signed-off-by: Logan McAnsh <logan@mcan.sh> update warning Signed-off-by: Logan McAnsh <logan@mcan.sh>

… the warning ending up in stderr Signed-off-by: Logan McAnsh <logan@mcan.sh>

brophdawg11 · 2023-03-06T17:17:21Z

packages/remix-dev/config.ts

@@ -727,3 +732,4 @@ let listFormat = new Intl.ListFormat("en", {
 });

 export let serverBuildTargetWarning = `The "serverBuildTarget" config option is deprecated. Use a combination of "publicPath", "serverBuildPath", "serverConditions", "serverDependenciesToBundle", "serverMainFields", "serverMinify", "serverModuleFormat" and/or "serverPlatform" instead.`;
+export let flatRoutesWarning = `The old route convention has been deprecated in favor of "flat routes". Please enable it via your remix.config https://remix.run/docs/en/main/file-conventions/route-files-v2`;


Should we prefix this with `⚠️ DEPRECATED: or something to make it stand out a bit more?

Suggested change

export let flatRoutesWarning = `The old route convention has been deprecated in favor of "flat routes". Please enable it via your remix.config https://remix.run/docs/en/main/file-conventions/route-files-v2`;

export let flatRoutesWarning = `⚠️ DEPRECATED: The old nested folders route convention has been deprecated in favor of "flat routes. Please enable the new routing convention via the \`future.v2_routeConvention\` flag in your \`remix.config.js\` file. For more information, please see https://remix.run/docs/en/main/file-conventions/route-files-v2.`;

Eventually I'd love to see it in yellow via chalk or something but I know we have future CLI improvements in the pipeline so probably worth waiting for that before doing anything too wild.

I wonder if we should also make sure we have a section in the new docs on "here's how to continue using the old nested folders version via defineRoutes"

I wonder if we should also make sure we have a section in the new docs on "here's how to continue using the old nested folders version via defineRoutes"

agreed, i ripped out the old convention as @mcansh/remix-v1-routes, but there may be further tweaking needed once #5649 and #5634 are done

Eventually I'd love to see it in yellow via chalk or something but I know we have future CLI improvements in the pipeline so probably worth waiting for that before doing anything too wild.

we can do this if we either make all warnOnce uses yellow or an arg passed to it

all uses of warnOnce could benefit from being yellow imo

sessions not being signed

cookies have expires setup

flat routes v2

serverBuildTarget

Signed-off-by: Logan McAnsh <logan@mcan.sh>

github-actions · 2023-03-07T07:09:35Z

🤖 Hello there,

We just published version v0.0.0-nightly-e78a09b-20230307 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

… is not enabled (#5606)" This reverts commit 712732f.

remix-cla-bot bot added the CLA Signed label Feb 28, 2023

mcansh force-pushed the logan/deprecate-old-route-convention branch 3 times, most recently from 82b723e to b75bc13 Compare March 1, 2023 22:28

mcansh added 2 commits March 2, 2023 13:18

Create .changeset/lazy-dots-sip.md

d9a0228

mcansh force-pushed the logan/deprecate-old-route-convention branch from b75bc13 to d9a0228 Compare March 2, 2023 18:20

test: update hmr test to use flat routes, otherwise it'll fail due to…

d9b9049

… the warning ending up in stderr Signed-off-by: Logan McAnsh <logan@mcan.sh>

mcansh force-pushed the logan/deprecate-old-route-convention branch from b972de8 to d9b9049 Compare March 6, 2023 16:20

mcansh changed the title ~~chore(remix-dev): add warning when future.v2_routeConvention is not enabled~~ feat(remix-dev): add warning when future.v2_routeConvention is not enabled Mar 6, 2023

brophdawg11 reviewed Mar 6, 2023

View reviewed changes

brophdawg11 approved these changes Mar 6, 2023

View reviewed changes

mcansh added 3 commits March 6, 2023 12:30

chore: update deprecation warning to include emoji

d74353b

Signed-off-by: Logan McAnsh <logan@mcan.sh>

chore: use export in integration test

696b09c

Signed-off-by: Logan McAnsh <logan@mcan.sh>

chore: use source, add dev to integration references

47a9ace

Signed-off-by: Logan McAnsh <logan@mcan.sh>

jacob-ebey approved these changes Mar 6, 2023

View reviewed changes

mcansh merged commit 712732f into dev Mar 6, 2023

mcansh deleted the logan/deprecate-old-route-convention branch March 6, 2023 18:36

github-actions bot added the awaiting release This issue has been fixed and will be released soon label Mar 6, 2023

MichaelDeBoey mentioned this pull request Mar 7, 2023

templates: enable v2_routeConvention config flag by default #5693

Merged

MichaelDeBoey added the package:dev label Mar 7, 2023

This was referenced Mar 9, 2023

chore: Update version for release #5740

Closed

chore: Update version for release (pre) #5741

Merged

mcansh added a commit that referenced this pull request Mar 14, 2023

Revert "feat(remix-dev): add warning when future.v2_routeConvention…

a163705

… is not enabled (#5606)" This reverts commit 712732f.

mcansh mentioned this pull request Mar 14, 2023

chore: remove deprecations #5790

Merged

2 tasks

mcansh added a commit that referenced this pull request Mar 14, 2023

Revert "feat(remix-dev): add warning when future.v2_routeConvention…

2abe0d0

… is not enabled (#5606)" This reverts commit 712732f.

mcansh mentioned this pull request Mar 14, 2023

feat: bring back old routing and serverBuildTarget deprecation warnings #5793

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(remix-dev): add warning when `future.v2_routeConvention` is not enabled #5606

feat(remix-dev): add warning when `future.v2_routeConvention` is not enabled #5606

mcansh commented Feb 28, 2023 •

edited

Loading

changeset-bot bot commented Feb 28, 2023 •

edited

Loading

brophdawg11 Mar 6, 2023

brophdawg11 Mar 6, 2023 •

edited

Loading

mcansh Mar 6, 2023 •

edited

Loading

mcansh Mar 6, 2023

mcansh Mar 6, 2023

github-actions bot commented Mar 7, 2023

	export let flatRoutesWarning = `The old route convention has been deprecated in favor of "flat routes". Please enable it via your remix.config https://remix.run/docs/en/main/file-conventions/route-files-v2`;
	export let flatRoutesWarning = `⚠️ DEPRECATED: The old nested folders route convention has been deprecated in favor of "flat routes. Please enable the new routing convention via the \`future.v2_routeConvention\` flag in your \`remix.config.js\` file. For more information, please see https://remix.run/docs/en/main/file-conventions/route-files-v2.`;

feat(remix-dev): add warning when future.v2_routeConvention is not enabled #5606

feat(remix-dev): add warning when future.v2_routeConvention is not enabled #5606

Conversation

mcansh commented Feb 28, 2023 • edited Loading

changeset-bot bot commented Feb 28, 2023 • edited Loading

🦋 Changeset detected

brophdawg11 Mar 6, 2023

Choose a reason for hiding this comment

brophdawg11 Mar 6, 2023 • edited Loading

Choose a reason for hiding this comment

mcansh Mar 6, 2023 • edited Loading

Choose a reason for hiding this comment

mcansh Mar 6, 2023

Choose a reason for hiding this comment

mcansh Mar 6, 2023

Choose a reason for hiding this comment

github-actions bot commented Mar 7, 2023

feat(remix-dev): add warning when `future.v2_routeConvention` is not enabled #5606

feat(remix-dev): add warning when `future.v2_routeConvention` is not enabled #5606

mcansh commented Feb 28, 2023 •

edited

Loading

changeset-bot bot commented Feb 28, 2023 •

edited

Loading

brophdawg11 Mar 6, 2023 •

edited

Loading

mcansh Mar 6, 2023 •

edited

Loading