feat!: remove v1 route convention codepaths #5649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 012f63f The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
MichaelDeBoey
added
the
BREAKING CHANGE
brophdawg11
removed
the
BREAKING CHANGE
mcansh
force-pushed
the
logan/remove-v1-route-convention
branch
from
f44f36a to
4f86104
Compare
MichaelDeBoey
approved these changes
Mar 10, 2023
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mcansh
force-pushed
the
logan/remove-v1-route-convention
branch
from
4b67140 to
9bbc4ea
Compare
[skip ci] Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh> test: remove old test Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mcansh
force-pushed
the
logan/remove-v1-route-convention
branch
from
813e03b to
9bc0435
Compare
[skip ci] Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
MichaelDeBoey
approved these changes
Mar 23, 2023
MichaelDeBoey
added
the
BREAKING CHANGE
MichaelDeBoey
pushed a commit
that referenced
this pull request
Jul 10, 2023
Co-authored-by: Matt Brophy <matt@brophy.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo:
thoughts:
when removing something from
futureshould we warn when we detect someone has it?Closes: #
Testing Strategy: