Alternative approach to previous PR. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abstract-database-+-hydration-to-dynamically-change-uiux-based-on-sign-up-source vn(feat) flowtime(0:52): working on schemas
vn(git) rebase encord with dev
(vn) rebase with encord
…on set, switching to main git user because of vercel billing
…g on a pragma called nsx. just because i want to look fancy. jokes aside, i want js-in-css without emotion/styled-components at build time :)
…ess is doing random refactors like this. It soothes me and makes me think clearer about things.
…from it. and then the app going back to something that makes sense again.
angeloreale
commented
Feb 6, 2024
There was a problem hiding this comment.
there is a lot of stub code, anticipating our design system, jsx pragma and the oplog.
but I'm merging this PR to favor progress over complexity, and will move forward with the services/feature flag in a subsequent PR, which will actually add the ability to toggle nav items based on tenant: orgs, users, and flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE REVIEW YOUR OWN PR BEFORE OPENING/UN-DRAFTING IT
EC-002
This is a simplified version of the Tenancy system.
Ideally I'd like to finish the oplog too, but that was increasing the complexity of the ORM exponentially and it was just a a personal exercise/stretch.
#2
Have you?
If so, THANKS! You can pop a beer/soda.
Please open your PR and ping your colleagues to review it on #web-devs channel.
Also, make sure to remind them on a daily basis during stand-up.