Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.ts files don't get vendored #790

Closed
jespertheend opened this issue Oct 11, 2023 · 0 comments · Fixed by #791
Closed

.ts files don't get vendored #790

jespertheend opened this issue Oct 11, 2023 · 0 comments · Fixed by #791
Assignees
Labels
effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase
Milestone

Comments

@jespertheend
Copy link
Collaborator

When a user vendors mod.js most of the required files are vendored. But files such as src/math/types.ts don't.
This is not an issue when you want to run code from Renda in the browser, but types such as Vec3ParameterSingle become any.

An workaround for users could be to vendor including type imports, but this will also result in a lot of studio types getting vendored.

Ideally the core of Renda shouldn't contain any .ts files. The few files that are currently there shouldn't be too difficult to convert to JSDoc.
Type files inside the /studio/ directory can remain there, as they likely won't need to be vendored anyway.

@jespertheend jespertheend added the effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase label Oct 11, 2023
@jespertheend jespertheend added this to the MVP milestone Oct 11, 2023
@jespertheend jespertheend self-assigned this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant