Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Convert typescript files to js #791

Merged
merged 2 commits into from
Oct 11, 2023
Merged

refactor: Convert typescript files to js #791

merged 2 commits into from
Oct 11, 2023

Conversation

jespertheend
Copy link
Collaborator

Fixes #790

@jespertheend jespertheend marked this pull request as ready for review October 11, 2023 21:28
@jespertheend
Copy link
Collaborator Author

Seems like there are three type files remaining:

  • src/util/gltf/types.ts is only used by internal code, the user likely doesn't need these anyway
  • src/components/types.ts this imports from studio/src/ui/propertiesTreeView/types.ts so moving this to a js file wouldn't solve anything
  • src/util/binarySerializationTypes.ts this seems too big to move for now, and I haven't really needed these types outside of studio yet.

@jespertheend jespertheend merged commit 266243a into rendajs:main Oct 11, 2023
8 checks passed
@jespertheend jespertheend deleted the 790-ts-files-dont-get-vendored branch October 11, 2023 21:34
@jespertheend jespertheend mentioned this pull request Mar 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.ts files don't get vendored
1 participant
@jespertheend