fix: fix failed hermit binary source tests due to findUp module acts differently in windows #16985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…differently in windows
|
@viceice please take a look. and also please label this PR with |
rarkins
previously approved these changes
Aug 5, 2022
viceice
requested changes
Aug 5, 2022
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…ove mockResolvedValueOnce('')
viceice
approved these changes
Aug 5, 2022
6 tasks
|
🎉 This PR is included in version 32.146.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes failed hermit binary source tests. It uses the same way as how
findUpLocaltests sets up thefind-upmocks inlib/util/fs/index.spec.tsThe failed tests result is in the following.
https://github.com/renovatebot/renovate/runs/7685608162?check_suite_focus=true#step:7:306
Context
This happens after the merge of #16259
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: