Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: rename renovate/stability-days check to renovate/minimum-release-age #22704

Closed
wants to merge 22 commits into from
Closed

refactor!: rename renovate/stability-days check to renovate/minimum-release-age #22704

wants to merge 22 commits into from

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jun 12, 2023

Changes

Renames renovate/stability-days check to be renovate/minimum-release-age.

Context

Closes #21442

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins and others added 9 commits June 12, 2023 13:49
@rarkins @HonkingGoose
feat!: allow post upgrade templating by default (#21326)
1169d19 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins @HonkingGoose
feat(automerge)!: default to platformAutomerge=true (#21327)
a9f5219 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@viceice @rarkins
feat(platform/gitlab)!: prefer commit_email (#21122
c1b63f6 
gitAuthor discover for GitLab now prefers the field `commit_email` over `email`.

BREAKING CHANGE: GitLab gitAuthor will change from the account's "email" to "commit_email" if they are different.
@bgutschke @rarkins
fix(post-upgrade-tasks)!: enable dot option for file filters (#21282)
ca7357f 
Set `{ dot: true }` for minimatch.

BREAKING CHANGE: dot files will now be included by default for all minimatch results
@rarkins
feat(npm)!: disable rollbackPrs for npm by default (#21970)
bbc72d9
@rarkins
fix(presets)!: remove compatibility:additionalBranchPrefix (#22015)
3f432a4
@rarkins
feat(package-rules)!: remove fuzzy matchPaths matching (#22394)
6e95ba7
@rarkins
feat!: merge matchPaths and matchFiles into matchFileNames (#22406)
107e2bc
@rarkins
refactor!: rename renovate/stability-days check to renovate/minimum-r…
fa90bf3 
…elease-age

Closes #21442
@rarkins rarkins requested a review from viceice June 12, 2023 14:44
@rarkins rarkins added the breaking Breaking change, requires major version bump label Jun 12, 2023
rarkins and others added 8 commits June 12, 2023 16:50
@rarkins @HonkingGoose
feat!: allow post upgrade templating by default (#21326)
d2c6725 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins @HonkingGoose
feat(automerge)!: default to platformAutomerge=true (#21327)
4c0bb3a 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@viceice @rarkins
feat(platform/gitlab)!: prefer commit_email (#21122
94d73e4 
gitAuthor discover for GitLab now prefers the field `commit_email` over `email`.

BREAKING CHANGE: GitLab gitAuthor will change from the account's "email" to "commit_email" if they are different.
@bgutschke @rarkins
fix(post-upgrade-tasks)!: enable dot option for file filters (#21282)
4d95133 
Set `{ dot: true }` for minimatch.

BREAKING CHANGE: dot files will now be included by default for all minimatch results
@rarkins
feat(npm)!: disable rollbackPrs for npm by default (#21970)
1b0570a
@rarkins
fix(presets)!: remove compatibility:additionalBranchPrefix (#22015)
90975fb
@rarkins
feat(package-rules)!: remove fuzzy matchPaths matching (#22394)
88ab057
@rarkins
feat!: merge matchPaths and matchFiles into matchFileNames (#22406)
86831e4
@rarkins rarkins requested a review from viceice June 12, 2023 16:22
rarkins and others added 3 commits June 12, 2023 19:38
viceice
viceice previously approved these changes Jun 12, 2023
View reviewed changes
HonkingGoose
HonkingGoose reviewed Jun 12, 2023
View reviewed changes
lib/workers/repository/update/branch/index.ts
@@ -333,7 +333,7 @@ export async function processBranch(
) {
// Only set a stability status check if one or more of the updates contain
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to keep stability status check? It may get confusing now we renamed stabilityDays to minimumReleaseAge.

Same thing applies to line 325: //stability checks. 😉

docs/usage/configuration-options.md
@@ -1602,7 +1602,7 @@ If you are more interested in including only certain package managers (e.g. `npm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renovate-stabilitydays-in-pr-checks

I don't know if renaming the app/check-thing from renovate/stability-days to renovate/minimum-release-age is something you want to do. Renaming that is a breaking change, because users will need to update their "required tests before allowing merge" in their platform settings.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's in a major release, however app users won't have a choice. We could set both for a while, but that probably doesn't help things

Copy link
Collaborator

@HonkingGoose HonkingGoose Jun 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having both names is probably more confusing than a breaking rename to renovate/minimum-release-age. But in the short term having both is probably needed for users to switch without breakage to the new check.

How about something like this?

  1. Create the new check renovate/minimum-release-age
  2. Create a notice about "Switch to renovate/minimum-release-age check" in:
    • a pinned Issue
    • a pinned Discussion
    • our docs announcement bar
  3. After enough time remove the old renovate/stability-days check

Optional: use GitHub's brownout strategy, they sometimes break a feature intentionally, and put a comment in the log, so people go looking why things changed. That way they nudge users into updating before the feature is fully removed by GitHub.

@rarkins rarkins marked this pull request as draft June 13, 2023 07:45
@rarkins rarkins dismissed viceice’s stale review June 15, 2023 16:58

The merge-base changed after approval.

@rarkins rarkins force-pushed the v36 branch 2 times, most recently from d691aac to 93a7751 Compare June 18, 2023 07:48
@rarkins rarkins closed this Jun 18, 2023
@HonkingGoose HonkingGoose mentioned this pull request Jul 5, 2023
Open
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2023
@rarkins rarkins deleted the feat/21442-stability-days-check branch April 22, 2024 05:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose left review comments

@viceice viceice viceice left review comments

Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rarkins @viceice @HonkingGoose @bgutschke @RahulGautamSingh