-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: rename renovate/stability-days check to renovate/minimum-release-age #22704
Closed
Closed
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1169d19
feat!: allow post upgrade templating by default (#21326)
rarkins a9f5219
feat(automerge)!: default to platformAutomerge=true (#21327)
rarkins c1b63f6
feat(platform/gitlab)!: prefer `commit_email` (#21122
viceice ca7357f
fix(post-upgrade-tasks)!: enable dot option for file filters (#21282)
bgutschke bbc72d9
feat(npm)!: disable rollbackPrs for npm by default (#21970)
rarkins 3f432a4
fix(presets)!: remove compatibility:additionalBranchPrefix (#22015)
rarkins 6e95ba7
feat(package-rules)!: remove fuzzy matchPaths matching (#22394)
rarkins 107e2bc
feat!: merge matchPaths and matchFiles into matchFileNames (#22406)
rarkins fa90bf3
refactor!: rename renovate/stability-days check to renovate/minimum-r…
rarkins d2c6725
feat!: allow post upgrade templating by default (#21326)
rarkins 4c0bb3a
feat(automerge)!: default to platformAutomerge=true (#21327)
rarkins 94d73e4
feat(platform/gitlab)!: prefer `commit_email` (#21122
viceice 4d95133
fix(post-upgrade-tasks)!: enable dot option for file filters (#21282)
bgutschke 1b0570a
feat(npm)!: disable rollbackPrs for npm by default (#21970)
rarkins 90975fb
fix(presets)!: remove compatibility:additionalBranchPrefix (#22015)
rarkins 88ab057
feat(package-rules)!: remove fuzzy matchPaths matching (#22394)
rarkins 86831e4
feat!: merge matchPaths and matchFiles into matchFileNames (#22406)
rarkins e5574c6
feat!: remove `skipInstalls` config option (#22648)
RahulGautamSingh 223cdf1
Merge branch 'v36' into feat/21442-stability-days-check
rarkins ad78373
Update lib/workers/repository/update/branch/status-checks.ts
rarkins 8113e29
fix lint
rarkins dfcca82
fix test
rarkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if renaming the app/check-thing from
renovate/stability-days
torenovate/minimum-release-age
is something you want to do. Renaming that is a breaking change, because users will need to update their "required tests before allowing merge" in their platform settings.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's in a major release, however app users won't have a choice. We could set both for a while, but that probably doesn't help things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having both names is probably more confusing than a breaking rename to
renovate/minimum-release-age
. But in the short term having both is probably needed for users to switch without breakage to the new check.How about something like this?
renovate/minimum-release-age
renovate/minimum-release-age
check" in:renovate/stability-days
checkOptional: use GitHub's brownout strategy, they sometimes break a feature intentionally, and put a comment in the log, so people go looking why things changed. That way they nudge users into updating before the feature is fully removed by GitHub.