fix(cargo): fix handling of x
and x.y
versions
#26263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes the handling of cargo versions to be "caret by default".
Context
The Rustup project is now using what has been made available in #25983, which works well for an update from
1.2.0
to1.4.1
, for example, where the manifest is untouched under therangeStrategy: update-lockfile
mode.However, when an update from
1.2
to1.4
is detected, the manifest is still updated (see rust-lang/rustup#3569 (comment)).The root cause of this issue seems to be that the current implementation of cargo versioning incorrectly assumes the following:
renovate/lib/modules/versioning/cargo/index.ts
Lines 24 to 26 in b69416c
... however in cargo
1.2
is handled the same way as^1.2
, as documented in https://doc.rust-lang.org/stable/cargo/reference/specifying-dependencies.html#caret-requirements.This PR combined with the previous #25983 should be able to address rust-lang/rustup#3541.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: