Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update rust crate termcolor to 1.4 #3569

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 7, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
termcolor workspace.dependencies minor 1.2 -> 1.4

Release Notes

BurntSushi/termcolor (termcolor)

v1.4.0

Compare Source

v1.3.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@djc
Copy link
Contributor

djc commented Dec 7, 2023

This is like wrong again?

@rami3l
Copy link
Member

rami3l commented Dec 7, 2023

@djc Yes. Maybe the part of "what versions should be considered as compatible" is different across package managers. I'll look into it.

This time however, our repo won't need a config update again.


Update: Indeed, the "^ by default" thing in cargo is subtle here and might need a hack.

Is this right though? https://github.com/renovatebot/renovate/blob/b69416ce1745f67c9fc1d149738e2f52feb4f732/lib/modules/versioning/cargo/index.ts#L26

This part is not in the original patch so I didn't look at it until just now.

@djc
Copy link
Contributor

djc commented Dec 8, 2023

    // NOTE: Partial versions like '1.2' don't get converted to '^1.2'
    // because isVersion('1.2') === false
    // In cargo and in npm 1.2 is equivalent to 1.2.* so it is correct behavior.

It seems suspect? I don't know how isVersion() is used exactly. 1.2 in Cargo should be treated as ^1.2.0.

@djc djc closed this Dec 11, 2023
Copy link
Contributor Author

renovate bot commented Dec 11, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (1.4). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/termcolor-1.x branch December 11, 2023 08:22
@rami3l rami3l removed their assignment Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants