Support new base images #1890
Closed
Support new base images #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support base images based on torch patch versions.
* Adds torch 2.4.0 compatibility in the matrix * Add CuDNN to CUDA 12.4.x compatibility
* Use our torch audio from the cog base images instead
* Do not forward cu118 et al version modifiers
* We never want to useCogBaseImage when generating base images.
* Make sure the modifier is always stripped from torch (we don’t need it anymore) * Support major/minor versions of torch that resolve to latest patch version * Add the concept of a set Patch to version, that allows logic to know whether the patch version is explicitly set or not.
* Add the compatible versions of torchvision and torchaudio to the base image python packages
* When rendering the base image name, resolve the latest torch patch version if not supplied * Add BaseImageConfigurations that conform to the null CUDA
|
Isolating the torch patch version support in #1894 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will introduce a race condition, since building the base images relies on this matrix, and until that is run these base images will be invalid, so it should be done in close connection to the generation of those base images.