Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set useCogBaseImage to false in base-image #1892

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

8W9aG
Copy link
Contributor

@8W9aG 8W9aG commented Aug 21, 2024

  • We never want to useCogBaseImage when generating base images.

Currently if we execute ./base-images dockerfile --cuda 12.1.1 --torch 2.1.1 --python 3.11 we see the following:

#syntax=docker/dockerfile:1.4
FROM r8.im/cog-base:cuda12.1-python3.11-torch2.1
RUN --mount=type=cache,target=/var/cache/apt,sharing=locked apt-get update -qq && apt-get install -qqy  && rm -rf /var/lib/apt/lists/*

This is due to the generator thinking cog base images is turned on. This is because I changed the configuration to default to true if the user didn't explicitly define whether they wanted to use cog base images. Here we fix it by explicitly saying we don't want to use cog base images, this then forces the generator to produce a full base image rather than a stub.

* We never want to useCogBaseImage when generating
base images.
@8W9aG 8W9aG merged commit 2394064 into main Aug 21, 2024
15 checks passed
@8W9aG 8W9aG deleted the fix-cog-base-image-dockerfiles branch August 21, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants