Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Rename TS_WORKSPACE_DIR to TS_OUTPUT_DIR #1388

Closed
wants to merge 1 commit into from
Closed

fix: Rename TS_WORKSPACE_DIR to TS_OUTPUT_DIR #1388

wants to merge 1 commit into from

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Nov 8, 2023 •
edited
Loading

Description, Motivation and Context

Small improvement after reviewing replicatedhq/troubleshoot.sh#530 PR. TS_OUTPUT_DIR is a better name compared to TS_WORKSPACE_DIR since the purpose of this variable is to hold the directory path for outputs of the command. Its also created when inputDir is defined.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@banjoh banjoh requested a review from a team as a code owner November 8, 2023 16:51
@banjoh
Copy link
Member Author

banjoh commented Nov 9, 2023 •
edited
Loading

Closing this PR in favour of #1389 from the original author of the changes I tried to update

@banjoh banjoh closed this Nov 9, 2023
@banjoh banjoh deleted the em/rename-variable branch November 29, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type::chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@banjoh