Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing omitempty on 2 of the new fields #1389

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix: missing omitempty on 2 of the new fields #1389

merged 2 commits into from
Nov 9, 2023

Conversation

cwyl02
Copy link
Contributor

@cwyl02 cwyl02 commented Nov 8, 2023 •
edited by banjoh
Loading

Description, Motivation and Context

missing omitempty on ignoreParentEnvs and inheritEnvs. Without this change it's not backward compatible.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@cwyl02 cwyl02 requested a review from a team as a code owner November 8, 2023 21:20
@xavpaice xavpaice added type::bug Something isn't working bug::normal labels Nov 8, 2023
@banjoh banjoh mentioned this pull request Nov 9, 2023
Closed
6 tasks
@banjoh banjoh merged commit bc48568 into replicatedhq:main Nov 9, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banjoh banjoh banjoh approved these changes

Assignees
No one assigned
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwyl02 @banjoh @xavpaice