search: add nested aggregations support #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebdeleze
force-pushed
the
sed-search-aggregation-filters
branch
2 times, most recently
from
35f5012 to
9b036e3
Compare
|
@AoNoOokami I didn't have a real example of hierarchical facets. Could you test this PR on your side? |
sebdeleze
force-pushed
the
sed-search-aggregation-filters
branch
from
ca5b48c to
051cc2d
Compare
jma
reviewed
Apr 1, 2020
sebdeleze
force-pushed
the
sed-search-aggregation-filters
branch
from
051cc2d to
089c133
Compare
sebdeleze
changed the title
sebdeleze
force-pushed
the
sed-search-aggregation-filters
branch
from
089c133 to
0962562
Compare
jma
requested changes
Apr 2, 2020
projects/rero/ng-core/src/lib/record/search/aggregation/aggregation.component.html
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/aggregation/buckets/buckets.component.ts
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/record-search.component.html
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/record-search.component.ts
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/record-search.component.ts
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/search/record-search.component.ts
Outdated
Show resolved
Hide resolved
sebdeleze
force-pushed
the
sed-search-aggregation-filters
branch
2 times, most recently
from
78181dd to
e70e94d
Compare
|
@jma Everything should be resolved, there are just a few points left for which I have left comments. |
sebdeleze
force-pushed
the
sed-search-aggregation-filters
branch
2 times, most recently
from
db1571a to
71c5d18
Compare
sebdeleze
force-pushed
the
sed-search-aggregation-filters
branch
from
71c5d18 to
cdf8279
Compare
* Adds nested aggregations support. * Refactors RecordSearchComponent. * Unsubscribes from observables when components are destroyed. * Creates a RecordSearchService for handling aggregations filters. * Adapts menu component in order to include query parameters. * Sets aggregations buckets size to 8 in tester application. * Fixes "combineLatest" RxJS function deprecation warnings. * Exports RecordSearchService in public-api to use it outside ng-core. * Initializes filters to launch first search on homepage. Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch
sebdeleze
force-pushed
the
sed-search-aggregation-filters
branch
from
cdf8279 to
fd0fd70
Compare
AoNoOokami
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
Tested with rero/rero-ils#852 and rero/rero-ils-ui#208, on both public and admin views.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch