Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: fix query with trailing and leading space #158

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

AoNoOokami
Copy link

@AoNoOokami AoNoOokami commented Apr 1, 2020

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

https://tree.taiga.io/project/rero21-reroils/task/1386?kanban-status=1224894

How to test?

Needs to be tested in rero-ils-ui: rero/rero-ils-ui#219
See issue description: rero/rero-ils-ui#213

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message accordingly.

@AoNoOokami AoNoOokami force-pushed the zaa-#1386-trim-barcode branch 2 times, most recently from ca244d0 to c960329 Compare April 1, 2020 09:49
@AoNoOokami AoNoOokami changed the title search: trim barcode search: fix query with trailing and leading space Apr 1, 2020
* Adds an input property to remove trailing and leading space if needed.
* Removes weird character in licence text of the template.
* Closes rero/rero-ils-ui#213.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami removed the request for review from sebdeleze April 1, 2020 12:37
@AoNoOokami AoNoOokami merged commit b308e2a into rero:dev Apr 1, 2020
@AoNoOokami AoNoOokami deleted the zaa-#1386-trim-barcode branch April 20, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants