Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: remove useless code #219

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Apr 1, 2020

  • Removes previous fix that is useless now.
  • Removes weird character in the licence text of templates.

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

https://tree.taiga.io/project/rero21-reroils/task/1386?kanban-status=1224894

How to test?

Related to rero/ng-core#158.
See issue description: #213.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@AoNoOokami AoNoOokami force-pushed the zaa-#1386-trim-barcode branch 2 times, most recently from 1879b8b to c4c0ce2 Compare April 1, 2020 09:12
@AoNoOokami AoNoOokami self-assigned this Apr 1, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-#1386-trim-barcode branch 2 times, most recently from cecf8cb to 7bb2a06 Compare April 1, 2020 09:47
@AoNoOokami AoNoOokami changed the title search: fix query with trailing space search: fix query with trailing and leading space Apr 1, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-#1386-trim-barcode branch 2 times, most recently from d28c845 to d9c5a4e Compare April 1, 2020 09:57
@AoNoOokami AoNoOokami changed the title search: fix query with trailing and leading space search: remove useless code Apr 1, 2020
* Removes previous fix that is useless now.
* Removes weird character in the licence text of templates.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami requested review from zannkukai and removed request for sebdeleze April 1, 2020 12:37
@AoNoOokami AoNoOokami merged commit febaf66 into rero:dev Apr 1, 2020
@AoNoOokami AoNoOokami deleted the zaa-#1386-trim-barcode branch April 20, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants