dependency: update to angular 11 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
zannkukai
reviewed
Nov 26, 2020
Comment on lines
141
to
143
| return Array.isArray(this._routerLink) && this._routerLink.length > 0 | ||
| ? true | ||
| : false; |
There was a problem hiding this comment.
Note : We could simplify with only return (Array.isArray(this._routerLink) && this._routerLink.length > 0);
zannkukai
reviewed
Nov 26, 2020
| ) { } | ||
|
|
||
| /** | ||
| * hook OnInit | ||
| */ | ||
| ngOnInit() { | ||
| const initialState: any = this._modalService.config.initialState; |
zannkukai
reviewed
Nov 26, 2020
| if (!locale) { | ||
| locale = this._translateService.currentLanguage; | ||
| } | ||
|
|
||
| return super.transform(value, format, timezone, locale); | ||
| return super.transform(value); |
There was a problem hiding this comment.
Why removing format, timezone, locale from parameters ? There seem still valid in Angular11
iGormilhit
added
the
dev: dependencies
sebdeleze
reviewed
Nov 30, 2020
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| /* tslint:disable:no-unused-variable */ | |||
|
|
|||
| import { TestBed, async, inject } from '@angular/core/testing'; | |||
| import { TestBed, inject, waitForAsync } from '@angular/core/testing'; | |||
| @@ -40,6 +40,9 @@ import { isEmpty, orderedJsonSchema, removeEmptyValues } from './utils'; | |||
| import { LoadTemplateFormComponent } from './widgets/load-template-form/load-template-form.component'; | |||
| import { SaveTemplateFormComponent } from './widgets/save-template-form/save-template-form.component'; | |||
|
|
|||
| export interface JSONSchema7 extends JSONSchema7Base { | |||
| form: any; | |||
| } | |||
There was a problem hiding this comment.
maybe a space after the interface, as this is not linked to component. Or better in a specific file.
...ero/ng-core/src/lib/record/editor/widgets/load-template-form/load-template-form.component.ts
Outdated
Show resolved
Hide resolved
| if (!locale) { | ||
| locale = this._translateService.currentLanguage; | ||
| } | ||
|
|
||
| return super.transform(value, format, timezone, locale); | ||
| return super.transform(value); |
jma
force-pushed
the
maj-angular-11
branch
2 times, most recently
from
401a731 to
8e77c2e
Compare
Garfield-fr
requested changes
Dec 2, 2020
sebdeleze
approved these changes
Dec 2, 2020
Garfield-fr
approved these changes
Dec 2, 2020
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
How to test?
Code review check list