Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: update to angular 11 #445

Merged
merged 1 commit into from
Dec 3, 2020
Merged

dependencies: update to angular 11 #445

merged 1 commit into from
Dec 3, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Nov 25, 2020 •
edited
Loading

  • Changes travis test in favour of github action.
  • Removes locales from moment to reduce the bundle size.
  • Create a custom distribution to remove the dependencies to avoid
    installing useless node package in the final application
  • Removes multiple bootstrap inclusion.
  • Create a new JSONSchema7 interface to add the form options.
  • Updates third party dependencies, such as ngx-bootstrap, ngx-formly,
    etc.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • angular 8 is end of life

Dependencies

My PR depends on ng-core#308's PR(s):

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@jma jma force-pushed the maj-angular-11 branch 2 times, most recently from ab696b1 to 4c4ec28 Compare November 25, 2020 17:24
@iGormilhit iGormilhit changed the title dependency: update to angular 11 dependencies: update to angular 11 Nov 26, 2020
iGormilhit
iGormilhit reviewed Nov 26, 2020
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit title: from dependency to dependencies, mainly to be coherent with other commit titles.

@iGormilhit iGormilhit added the dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed label Nov 26, 2020
@iGormilhit iGormilhit added this to the v0.15.0 milestone Nov 26, 2020
@jma jma force-pushed the maj-angular-11 branch 2 times, most recently from a95ff87 to 442d7cf Compare November 30, 2020 13:59
@jma jma requested a review from iGormilhit November 30, 2020 14:03
@AoNoOokami AoNoOokami mentioned this pull request Dec 1, 2020
Closed
AoNoOokami
AoNoOokami reviewed Dec 1, 2020
View reviewed changes
Copy link
Contributor

@AoNoOokami AoNoOokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found an issue with the save as template feature. Didn't find any other issue.

iGormilhit
iGormilhit previously requested changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@iGormilhit iGormilhit dismissed their stale review December 3, 2020 06:08

Wrongfuly clicked on resquest changes instead of approve.

iGormilhit
iGormilhit approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@jma jma mentioned this pull request Dec 3, 2020
Merged
7 tasks
@jma jma requested a review from AoNoOokami December 3, 2020 07:26
@jma jma force-pushed the maj-angular-11 branch 4 times, most recently from 2d58824 to f2e4d59 Compare December 3, 2020 10:10
@jma
dependencies: update to angular 11
2500558 
* Changes travis test in favour of github action.
* Removes locales from moment to reduce the bundle size.
* Create a custom distribution to remove the dependencies to avoid
  installing useless node package in the final application
* Removes multiple bootstrap inclusion.
* Create a new JSONSchema7 interface to add the form options.
* Updates third party dependencies, such as ngx-bootstrap, ngx-formly,
  etc.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma merged commit a83e34d into rero:dev Dec 3, 2020
@jma jma deleted the maj-angular-11 branch February 11, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@AoNoOokami AoNoOokami Awaiting requested review from AoNoOokami

Assignees
No one assigned
Labels
dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jma @Garfield-fr @iGormilhit @zannkukai @AoNoOokami