assets: move to webpack #1537

jma · 2020-12-02T12:54:26Z

Fixes docker file to use a custom rero-ils-ui file.
Removes npm utils from the bootstrap script.
Removes angularjs translations extraction.
Moves all theme related files into a specific directory.
Removes all bundles files.
Removes useless INVENIO_SEARCH_UI configuration variables.
Includes the angular application with a custom manner: it does not
make sense to use invenio-assets for an already optimized bundle.
Removes js to store the last visited html tab, closes The tab displayed when opening a detailed view seems to be random. #1394.
Removes angularjs dependency.
Use simple code to generate thumbnails in the document detailed view.
Reduces the docker image size by cleaning several cache files.
Closes Static files on production delivers more file than expected ie. package-lock.json #713.

Why are you opening this PR?

To remove legacy code.

Dependencies

ng-core: 1.0.0
dependencies: update to angular 11 rero-ils-ui#445

How to test?

What command should I have to run to test your PR?
What should I test through the UI?

Code review check list

zannkukai · 2020-12-03T14:10:57Z

rero_ils/filter.py

+        to_return = '<script {tags} src="{value}"></script>'.format(
+                value=value,
+                tags=tags
+            )
+        if _type == 'css':
+            to_return = '<link {tags} href="{value}" rel="stylesheet">'.format(
+                value=value,
+                tags=tags
+            )
+        return to_return


if _type == 'css': return '<link {tags} href="{value}" rel="stylesheet">'.format( value=value, tags=tags ) return '<script {tags} src="{value}"></script>'.format( value=value, tags=tags )

It seems "dummy" to intitialize a variable and override it just after

zannkukai · 2020-12-03T14:12:20Z

rero_ils/modules/documents/templates/rero_ils/detailed_view_documents.html

+  <figure class="mb-0 thumb">
+    <img class="img-responsive border border-light"
+         src="{{record | get_cover_art}}"
+         onerror="this.src='{{url_for("static", filename="images/icon_%s.png" % record.type) }}'" >


It was your idea! Thanks.

zannkukai · 2020-12-03T14:13:47Z

rero_ils/modules/documents/utils.py

+        url, headers={'referer': flask_request.host_url})
+
+    if response.status_code != 200:
+        current_app.logger.warning(


It will log a looooooooot of message isn't it ? Maybe warning level isn't the best for this message ? info/debug ?

zannkukai · 2020-12-03T14:15:59Z

rero_ils/theme/assets/js/reroils/login.js

+  var sPageURL = window.location.search.substring(1),
+    sURLVariables = sPageURL.split('&'),
+    sParameterName,
+    i;


Mmmm.... strange construction, I would trust you

Me too, I found this code on the web and seems work.

iGormilhit

Commit message approved.

iGormilhit · 2020-12-03T14:30:51Z

rero_ils/config.py

@@ -197,13 +182,14 @@ def _(x):
 #: Template for error pages.
 THEME_ERROR_TEMPLATE = 'rero_ils/page_error.html'
 #: RERO-ils search endpoint (i.e /search/documents)
-RERO_ILS_THEME_SEARCH_ENDPOINT = '/search/documents'
+# RERO_ILS_THEME_SEARCH_ENDPOINT = '/search/documents'


Do you actually want to comment this, or do you want to remove it?

iGormilhit · 2020-12-03T14:37:07Z

rero_ils/theme/__init__.py

@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 #
 # RERO ILS
-# Copyright (C) 2020 RERO
+# Copyright (C) 2019 RERO


Why are you going in the past? I know, 2020 is an awful year, but still.

iGormilhit · 2020-12-03T14:37:24Z

rero_ils/theme/assets/js/reroils/login.js

+/*
+
+RERO ILS
+Copyright (C) 2019 RERO


Suggested change

Copyright (C) 2019 RERO

Copyright (C) 2020 RERO

iGormilhit · 2020-12-03T14:37:59Z

rero_ils/theme/assets/js/reroils/toggle.js

+/*
+
+RERO ILS
+Copyright (C) 2019 RERO


Suggested change

Copyright (C) 2019 RERO

Copyright (C) 2020 RERO

iGormilhit · 2020-12-03T14:38:14Z

rero_ils/theme/assets/js/reroils/tooltip.js

@@ -1,7 +1,7 @@
 /*

 RERO ILS
-Copyright (C) 2020 RERO
+Copyright (C) 2019 RERO


Suggested change

Copyright (C) 2019 RERO

Copyright (C) 2020 RERO

zannkukai · 2020-12-03T19:04:32Z

icon for ill request form is missing in the user "tool" menu

lauren-d · 2020-12-03T19:50:47Z

I'm not sure that is linked to angular 11.
There is a little bit strange "blink effect" when we use facets on any search view.
It seems the search is processed twice:

AoNoOokami · 2020-12-04T15:07:17Z

I'm not sure that is linked to angular 11.
There is a little bit strange "blink effect" when we use facets on any search view.
It seems the search is processed twice...

There is an issue about that: #1179

AoNoOokami · 2020-12-04T15:10:44Z

After the merge of previous PR to use Angular 11, brief and detailed views take too much space in width. There is a class main-content used in ng-core, to which a style is applied in rero-ils ui that should manage that. It seems ineffective now. Check that behaviour too in your PR please.
Context: #1514 and rero/rero-ils-ui#440 after rebase on rero/dev with rero-ils-ui integrated to rero-ils (localhost:5000).

AoNoOokami · 2020-12-04T15:58:48Z

I saw that it is not possible to do a request in the pro interface. The modal to enter patron barcode and choose pickup is not displayed. That makes several cypress tests fail.
Context: #1514 and rero/rero-ils-ui#440 after rebase on rero/dev with rero-ils-ui integrated to rero-ils (localhost:5000).

* Removes npm utils from the bootstrap script. * Removes angularjs translations extraction. * Moves all theme related files into a specific directory. * Removes all bundles files. * Removes useless INVENIO_SEARCH_UI configuration variables. * Includes the angular application with a custom manner: it does not make sense to use `invenio-assets` for an already optimized bundle. * Removes js to store the last visited html tab, closes rero#1394. * Removes angularjs dependency. * Use simple code to generate thumbnails in the document detailed view. * Reduces the docker image size by cleaning several cache files. * Closes rero#713. Signed-off-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>

jma · 2020-12-07T09:12:58Z

I'm not sure that is linked to angular 11.
There is a little bit strange "blink effect" when we use facets on any search view.
It seems the search is processed twice...

There is an issue about that: #1179

I don't think it is related to this issue. This happens on the search list view, not in the circulation.

jma · 2020-12-07T09:13:32Z

After the merge of previous PR to use Angular 11, brief and detailed views take too much space in width. There is a class main-content used in ng-core, to which a style is applied in rero-ils ui that should manage that. It seems ineffective now. Check that behaviour too in your PR please.
Context: #1514 and rero/rero-ils-ui#440 after rebase on rero/dev with rero-ils-ui integrated to rero-ils (localhost:5000).

Unable to reproduce.

jma · 2020-12-07T09:13:52Z

I saw that it is not possible to do a request in the pro interface. The modal to enter patron barcode and choose pickup is not displayed. That makes several cypress tests fail.
Context: #1514 and rero/rero-ils-ui#440 after rebase on rero/dev with rero-ils-ui integrated to rero-ils (localhost:5000).

unable to reproduce

jma force-pushed the maj-webpack branch from cb5d8f5 to 6c32bef Compare December 2, 2020 13:04

jma changed the title ~~Maj webpack~~ assets: move to webpack Dec 2, 2020

jma force-pushed the maj-webpack branch 11 times, most recently from b4aa9a2 to c60c897 Compare December 3, 2020 07:25

jma marked this pull request as ready for review December 3, 2020 07:25

jma requested review from benerken, Garfield-fr, zannkukai and iGormilhit December 3, 2020 07:26

jma force-pushed the maj-webpack branch 2 times, most recently from ffec4a4 to 3ef3d6f Compare December 3, 2020 12:18

Garfield-fr approved these changes Dec 3, 2020

View reviewed changes

jma force-pushed the maj-webpack branch 2 times, most recently from 6cee8b0 to 40fcec9 Compare December 3, 2020 14:02

zannkukai reviewed Dec 3, 2020

View reviewed changes

zannkukai approved these changes Dec 3, 2020

View reviewed changes

iGormilhit suggested changes Dec 3, 2020

View reviewed changes

iGormilhit added the dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed label Dec 3, 2020

iGormilhit added this to the v0.15.0 milestone Dec 3, 2020

jma force-pushed the maj-webpack branch from 40fcec9 to 68ce711 Compare December 7, 2020 09:09

jma merged commit 02e514e into rero:dev Dec 7, 2020

jma deleted the maj-webpack branch January 13, 2022 14:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

assets: move to webpack #1537

assets: move to webpack #1537

jma commented Dec 2, 2020 •

edited

Loading

zannkukai Dec 3, 2020

zannkukai Dec 3, 2020

jma Dec 7, 2020

zannkukai Dec 3, 2020

zannkukai Dec 3, 2020

jma Dec 7, 2020

iGormilhit left a comment

iGormilhit Dec 3, 2020

iGormilhit Dec 3, 2020

iGormilhit Dec 3, 2020

iGormilhit Dec 3, 2020

iGormilhit Dec 3, 2020

zannkukai commented Dec 3, 2020

lauren-d commented Dec 3, 2020

AoNoOokami commented Dec 4, 2020 •

edited

Loading

AoNoOokami commented Dec 4, 2020 •

edited

Loading

AoNoOokami commented Dec 4, 2020 •

edited

Loading

jma commented Dec 7, 2020

jma commented Dec 7, 2020

jma commented Dec 7, 2020

assets: move to webpack #1537

assets: move to webpack #1537

Conversation

jma commented Dec 2, 2020 • edited Loading

Why are you opening this PR?

Dependencies

How to test?

Code review check list

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iGormilhit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zannkukai commented Dec 3, 2020

lauren-d commented Dec 3, 2020

AoNoOokami commented Dec 4, 2020 • edited Loading

AoNoOokami commented Dec 4, 2020 • edited Loading

AoNoOokami commented Dec 4, 2020 • edited Loading

jma commented Dec 7, 2020

jma commented Dec 7, 2020

jma commented Dec 7, 2020

jma commented Dec 2, 2020 •

edited

Loading

AoNoOokami commented Dec 4, 2020 •

edited

Loading

AoNoOokami commented Dec 4, 2020 •

edited

Loading

AoNoOokami commented Dec 4, 2020 •

edited

Loading