circulation policy: improve editor #440
Merged
+604
−385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
force-pushed
the
zaa-#1882-improve-cipo-editor
branch
6 times, most recently
from
55613cf to
7e9cf2d
Compare
iGormilhit
added
f: circulation
AoNoOokami
force-pushed
the
zaa-#1882-improve-cipo-editor
branch
7 times, most recently
from
a04c2c6 to
9316c3b
Compare
Garfield-fr
reviewed
Nov 26, 2020
...cord/custom-editor/circulation-settings/circulation-policy/circulation-policy.component.html
Outdated
Show resolved
Hide resolved
...cord/custom-editor/circulation-settings/circulation-policy/circulation-policy.component.html
Outdated
Show resolved
Hide resolved
...cord/custom-editor/circulation-settings/circulation-policy/circulation-policy.component.html
Outdated
Show resolved
Hide resolved
| <div class="col-sm-3 p-0"> | ||
| <div class="input-group"> | ||
| <div class="input-group-prepend"> | ||
| <span class="input-group-text">{{ currency }}</span> |
There was a problem hiding this comment.
No because its a symbol
There was a problem hiding this comment.
That's right. We shouldn't need to translate currency symbols: https://github.com/rero/rero-ils/blob/dc3caa5b3d9edd3812e90c7b6dc3838ff98d5f2c/rero_ils/modules/vendors/jsonschemas/vendors/vendor-v0.0.1.json#L245
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Show resolved
Hide resolved
zannkukai
requested changes
Nov 26, 2020
...s/admin/src/app/record/custom-editor/circulation-settings/circulation-policy-form.service.ts
Show resolved
Hide resolved
...s/admin/src/app/record/custom-editor/circulation-settings/circulation-policy-form.service.ts
Show resolved
Hide resolved
...s/admin/src/app/record/custom-editor/circulation-settings/circulation-policy-form.service.ts
Outdated
Show resolved
Hide resolved
...s/admin/src/app/record/custom-editor/circulation-settings/circulation-policy-form.service.ts
Outdated
Show resolved
Hide resolved
...s/admin/src/app/record/custom-editor/circulation-settings/circulation-policy-form.service.ts
Outdated
Show resolved
Hide resolved
...s/admin/src/app/record/custom-editor/circulation-settings/circulation-policy-form.service.ts
Outdated
Show resolved
Hide resolved
...s/admin/src/app/record/custom-editor/circulation-settings/circulation-policy-form.service.ts
Outdated
Show resolved
Hide resolved
AoNoOokami
force-pushed
the
zaa-#1882-improve-cipo-editor
branch
from
9316c3b to
784a1e0
Compare
iGormilhit
suggested changes
Nov 30, 2020
There was a problem hiding this comment.
Commit message proposition:
circulation policy: improve editor
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
tests and improve its appearance.
* Removes useless code.
...cord/custom-editor/circulation-settings/circulation-policy/circulation-policy.component.html
Outdated
Show resolved
Hide resolved
...cord/custom-editor/circulation-settings/circulation-policy/circulation-policy.component.html
Outdated
Show resolved
Hide resolved
...cord/custom-editor/circulation-settings/circulation-policy/circulation-policy.component.html
Outdated
Show resolved
Hide resolved
...cord/custom-editor/circulation-settings/circulation-policy/circulation-policy.component.html
Outdated
Show resolved
Hide resolved
...cord/custom-editor/circulation-settings/circulation-policy/circulation-policy.component.html
Outdated
Show resolved
Hide resolved
| <div class="col-sm-3 p-0"> | ||
| <div class="input-group"> | ||
| <div class="input-group-prepend"> | ||
| <span class="input-group-text">{{ currency }}</span> |
There was a problem hiding this comment.
That's right. We shouldn't need to translate currency symbols: https://github.com/rero/rero-ils/blob/dc3caa5b3d9edd3812e90c7b6dc3838ff98d5f2c/rero_ils/modules/vendors/jsonschemas/vendors/vendor-v0.0.1.json#L245
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Show resolved
Hide resolved
AoNoOokami
force-pushed
the
zaa-#1882-improve-cipo-editor
branch
3 times, most recently
from
9f83bfb to
281aa49
Compare
zannkukai
approved these changes
Nov 30, 2020
AoNoOokami
force-pushed
the
zaa-#1882-improve-cipo-editor
branch
from
281aa49 to
f06d384
Compare
AoNoOokami
changed the title
AoNoOokami
force-pushed
the
zaa-#1882-improve-cipo-editor
branch
3 times, most recently
from
c9dca75 to
1f54706
Compare
iGormilhit
approved these changes
Dec 2, 2020
AoNoOokami
force-pushed
the
zaa-#1882-improve-cipo-editor
branch
3 times, most recently
from
9a4cd00 to
807b905
Compare
benerken
approved these changes
Dec 4, 2020
AoNoOokami
force-pushed
the
zaa-#1882-improve-cipo-editor
branch
from
807b905 to
0ce5603
Compare
7 tasks
AoNoOokami
force-pushed
the
zaa-#1882-improve-cipo-editor
branch
from
0ce5603 to
e9997de
Compare
* Moves buttons to the top to harmonize with other editors. * Corrects editor validation. * Improves editor appearance. * Closes rero/rero-ils#1365. * Closes rero/rero-ils#1305. * Adds id HTML attribute to circulation policy detail view for Cypress tests and improve its appearance. * Removes useless code. * Closes rero/rero-ils#1363. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-#1882-improve-cipo-editor
branch
from
e9997de to
d7b4338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests and improve its appearance.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
This is part of US1759
Dependencies
My PR depends on
rero-ils#<xx>'s PR(s):rero/rero-ils#1477
How to test?
Login as a librarian and check the cipo editor.
Create a cipo with checkout duration = 0 days.
Create an item linked to this cipo.
Try to check it out, and then check it in for a patron that is also linked to this cipo.
Code review check list