Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some circulation policy fields can have negative values or be zero. #1365

Closed
pronguen opened this issue Nov 4, 2020 · 0 comments · Fixed by rero/rero-ils-ui#440
Closed

Some circulation policy fields can have negative values or be zero. #1365

pronguen opened this issue Nov 4, 2020 · 0 comments · Fixed by rero/rero-ils-ui#440
Assignees
@AoNoOokami
Labels
f: circulation Concerns the circulation interface or backend f: editor Concerns editor based on JSON schema AND custom editor p-Low Low priority
Milestone
v0.15.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 4, 2020

How it works

  • Negative integers can be entered in number_of_renewals
  • Zero cannot be entered in number_of_days_before_due_date. The validation message is correct but the editor cannot be saved.

Expected behavior

  • number_of_renewals should contains only positive integers or zero
  • number_of_days_before_due_date should be able to contain zero

Context

  • server: ilspilot.test.rero.ch
  • version: v0.12.0

Additional context

Proposed by pilot libraries

Screenshots

image
@pronguen pronguen added triage p-Low Low priority labels Nov 4, 2020
@iGormilhit iGormilhit added f: circulation Concerns the circulation interface or backend f: editor Concerns editor based on JSON schema AND custom editor and removed triage labels Nov 4, 2020
@AoNoOokami AoNoOokami assigned AoNoOokami and unassigned Garfield-fr Nov 25, 2020
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 25, 2020
cipo: improve custom editor
9316c3b 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id html attribute to cipo detail view for Cypress tests and
improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Nov 25, 2020
Merged
6 tasks
@AoNoOokami AoNoOokami added this to the v0.15.0 milestone Nov 27, 2020
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 27, 2020
cipo: improve custom editor
784a1e0 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id html attribute to cipo detail view for Cypress tests and
improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 30, 2020
circulation policy: improve editor
4bbddde 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 30, 2020
circulation policy: improve editor
9f83bfb 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 30, 2020
circulation policy: improve editor
281aa49 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 1, 2020
circulation policy: improve editor
f06d384 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 1, 2020
circulation policy: improve editor
4148b95 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 1, 2020
circulation policy: improve editor
c9dca75 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 1, 2020
circulation policy: improve editor
1f54706 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 2, 2020
circulation policy: improve editor
9d9ee3b 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 4, 2020
circulation policy: improve editor
9a4cd00 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 4, 2020
circulation policy: improve editor
807b905 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 4, 2020
circulation policy: improve editor
0ce5603 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 9, 2020
circulation policy: improve editor
e9997de 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 10, 2020
circulation policy: improve editor
d7b4338 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to rero/rero-ils-ui that referenced this issue Dec 10, 2020
@AoNoOokami
circulation policy: improve editor
3855dbd 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AoNoOokami AoNoOokami

Labels
f: circulation Concerns the circulation interface or backend f: editor Concerns editor based on JSON schema AND custom editor p-Low Low priority
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

circulation policy: improve editor AoNoOokami/rero-ils-ui
4 participants
@Garfield-fr @iGormilhit @pronguen @AoNoOokami