Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels of the circulation policy editor shoud be improved. #1305

Closed
pronguen opened this issue Oct 15, 2020 · 0 comments · Fixed by rero/rero-ils-ui#440
Closed

Labels of the circulation policy editor shoud be improved. #1305

pronguen opened this issue Oct 15, 2020 · 0 comments · Fixed by rero/rero-ils-ui#440
Assignees
@AoNoOokami
Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend p-Medium Medium priority (to be solved within 1-2 years) wording When text is concerned, label, message, actions…
Milestone
v0.15.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Oct 15, 2020 •
edited
Loading

How it works

The labels of the circulation policy are not understandable:

  • First reminder days (below Send first reminder).
  • Days before due date (below Sending how many days after due date).
  • Fees (EUR) (below Fees fo this notification [currency]).

Improvement suggestion

We should have

A section "Send a loan expiry notice" (with toggle). If activated:

  • "Sending how many days before the due date"

A section "Send a first reminder" (with toggle). If activated:

  • "Sending how many days after the due date"
  • Fees for this notification ([currency])

See mockup on https://tree.taiga.io/project/rero21-reroils/us/1759

The following sections will be added through a user story:

A section "Send a second reminder" (with toggle). If activated:

  • "Sending how many days after the due date"
  • Fees for this notification ([currency])

A section "Send a third reminder" (with toggle). If activated:

  • "Sending how many days after the due date"
  • Fees for this notification ([currency])

A section "Send an invoice" (with toggle). If activated:

  • "Sending how many days after the due date"

Context

Proposed by pilot libraries
@pronguen pronguen added enhancement Improvement of an existing feature triage f: circulation Concerns the circulation interface or backend labels Oct 15, 2020
@iGormilhit iGormilhit changed the title Write a full sentence: The language selector menu shoud propose a default value. Labels of the circulation policy editor shoud be improved. Oct 21, 2020
@iGormilhit iGormilhit added wording When text is concerned, label, message, actions… and removed triage labels Oct 21, 2020
@iGormilhit iGormilhit added this to the v0.15.0 milestone Nov 3, 2020
@pronguen pronguen mentioned this issue Nov 4, 2020
Merged
6 tasks
@AoNoOokami AoNoOokami self-assigned this Nov 25, 2020
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 25, 2020
cipo: improve custom editor
9316c3b 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id html attribute to cipo detail view for Cypress tests and
improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Nov 25, 2020
Merged
6 tasks
@iGormilhit iGormilhit added the p-Medium Medium priority (to be solved within 1-2 years) label Nov 26, 2020
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 27, 2020
cipo: improve custom editor
784a1e0 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id html attribute to cipo detail view for Cypress tests and
improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 30, 2020
circulation policy: improve editor
4bbddde 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 30, 2020
circulation policy: improve editor
9f83bfb 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 30, 2020
circulation policy: improve editor
281aa49 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 1, 2020
circulation policy: improve editor
f06d384 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 1, 2020
circulation policy: improve editor
4148b95 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 1, 2020
circulation policy: improve editor
c9dca75 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 1, 2020
circulation policy: improve editor
1f54706 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 2, 2020
circulation policy: improve editor
9d9ee3b 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 4, 2020
circulation policy: improve editor
9a4cd00 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 4, 2020
circulation policy: improve editor
807b905 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 4, 2020
circulation policy: improve editor
0ce5603 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 9, 2020
circulation policy: improve editor
e9997de 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 10, 2020
circulation policy: improve editor
d7b4338 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to rero/rero-ils-ui that referenced this issue Dec 10, 2020
@AoNoOokami
circulation policy: improve editor
3855dbd 
* Moves buttons to the top to harmonize with other editors.
* Corrects editor validation.
* Improves editor appearance.
* Closes rero/rero-ils#1365.
* Closes rero/rero-ils#1305.
* Adds id HTML attribute to circulation policy detail view for Cypress
  tests and improve its appearance.
* Removes useless code.
* Closes rero/rero-ils#1363.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AoNoOokami AoNoOokami

Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend p-Medium Medium priority (to be solved within 1-2 years) wording When text is concerned, label, message, actions…
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

circulation policy: improve editor AoNoOokami/rero-ils-ui
3 participants
@iGormilhit @pronguen @AoNoOokami