Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circulation: hide buttons if action isn't available. #1354

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented Nov 2, 2020

If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
hide. In the patron profile view, adds warning/error messages depending
of patron restrictions.

Closes #1357
Closes #1356

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

How to test?

image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@zannkukai zannkukai added this to the v0.14.0 milestone Nov 2, 2020
@zannkukai zannkukai self-assigned this Nov 2, 2020
@zannkukai zannkukai force-pushed the zan-#1811-adapt-public-interface branch 4 times, most recently from 5d733f8 to 4ead1f9 Compare November 3, 2020 10:04
@zannkukai zannkukai marked this pull request as ready for review November 3, 2020 10:05
@zannkukai zannkukai force-pushed the zan-#1811-adapt-public-interface branch from 4ead1f9 to 1da66a3 Compare November 3, 2020 10:35
@zannkukai zannkukai force-pushed the zan-#1811-adapt-public-interface branch 2 times, most recently from 3c3a076 to 6b833aa Compare November 3, 2020 13:44
@zannkukai zannkukai force-pushed the zan-#1811-adapt-public-interface branch from 6b833aa to b43d054 Compare November 3, 2020 15:43
@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Nov 3, 2020

Like the #1357 the button 'request' should be visible even he has the limits reached, followed by an explanation. [enhancement]

@benerken
Copy link
Contributor

benerken commented Nov 3, 2020

Great job Renaud !
some comments for now:

  • If we define a general checkout limit only => the system displays a message when you arrive on the patron account in the professional view AND It displays a flash message when you do a checkout => OK
    (A permanent message is displayed in the patron public view) => OK

  • If we define a general checkout limit AND a library checkout limit => the system doesn't display a permanent message when you arrive on the patron account in the professional view. It displays a flash message when you do a checkout. Why ?
    (Same behaviour in the patron public view => No permanent message)

Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message body: replace twice disable by disabled. Thanks.

@zannkukai zannkukai force-pushed the zan-#1811-adapt-public-interface branch from b43d054 to 41cce3b Compare November 4, 2020 09:14
@pronguen
Copy link
Contributor

pronguen commented Nov 4, 2020

  • Wording
    • The unit of the field for each limit should be clearer in the field label (same problem than in cipo, Labels of the circulation policy editor shoud be improved. #1305).
    • I don't understand the word default in some of the labels.
    • The label should correspond to the description given below and does not need to repeat the info given in the toggle.
    • Suggestions:
      • Global checkout limit > Number of checkouts in the organisation
      • Default checkout limit by library > Number of checkouts by library
      • Default fee amount limit > Fee amount
      • Default overdue items limit > Number of overdue items
        image
  • Message in public interface (for patrons)
    • Don't display any message above, in the patron account (simplification), as they are note user-friendlyI think it is enough to display the message on the disabled buttons as tooltip.
      • Potential problem: the user does not know that he cannot request document. But if we display the request button in any case (sometimes disabled) it will solve this. See also Mana's comment [can be done later, issue can be opened].
    • Tooltips on buttons (request/renew): adapt if possible to end user, as specified in the US: "Renewal impossible: you have too many overdue items." / "Renewal impossible: you have too many fees." / etc.
    • Tootips in Google Chrome (Version 86.0.4240.183 (Build officiel) (64 bits)) is problematic: no tooltip for the first item to renew, other tooltip permanent (see screenshot)
    • This works on Firefox
      image
  • Circulation interface
    • Simplification of the flash message: the first part could be used as first line. In example below, use "Checkout denied" as first line.
      image
    • [enhancement] Ideally, the messages display above in user checkout account are adapted. Now they are answer messages after an action tried.
  • General
    • Limit by fee amount includes only overdue fees? Or it just does not include subscription fees? To decide, we may need to adapt the labels and messages.

@zannkukai zannkukai force-pushed the zan-#1811-adapt-public-interface branch 4 times, most recently from 48fd1d5 to 0fd4a1e Compare November 4, 2020 21:12
@zannkukai zannkukai force-pushed the zan-#1811-adapt-public-interface branch 2 times, most recently from 817e21f to 371a541 Compare November 5, 2020 13:53
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357
Closes rero#1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-#1811-adapt-public-interface branch from 371a541 to 2afc952 Compare November 5, 2020 14:20
@zannkukai zannkukai merged commit ac1d3c1 into rero:US1643-borrow-limits Nov 5, 2020
@zannkukai zannkukai deleted the zan-#1811-adapt-public-interface branch November 5, 2020 15:38
@iGormilhit iGormilhit added the f: circulation Concerns the circulation interface or backend label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
7 participants