Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display disabled "renew" button in patron account of the public interface #1357

Closed
pronguen opened this issue Nov 2, 2020 · 0 comments · Fixed by #1354
Closed

Display disabled "renew" button in patron account of the public interface #1357

pronguen opened this issue Nov 2, 2020 · 0 comments · Fixed by #1354
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend f: public ui Public interface, as opposed to the professional interface p-Low Low priority
Milestone
v0.14.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 2, 2020

How it works

In the public patron account, the "Renew" button is hidden if a renewal is not possible.

Improvement suggestion

The button is shown with an explanation:

  • This document cannot be renewed (if it is because of the circulation policy, max number of renewals reached)
  • *This document cannot be renewed because another person has requested it. (Else, if there is a pending loan)

Context

Proposed by pilot libraries
@pronguen pronguen added enhancement Improvement of an existing feature triage p-Low Low priority labels Nov 2, 2020
@zannkukai zannkukai self-assigned this Nov 3, 2020
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 3, 2020
@zannkukai
circulation: hide buttons if action isn't available.
4ead1f9 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai removed the triage label Nov 3, 2020
@zannkukai zannkukai linked a pull request Nov 3, 2020 that will close this issue
circulation: hide buttons if action isn't available. #1354
Merged
6 tasks
@zannkukai zannkukai mentioned this issue Nov 3, 2020
Merged
6 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 3, 2020
@zannkukai
circulation: hide buttons if action isn't available.
1da66a3 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357
Closes rero#1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 3, 2020
@zannkukai
circulation: hide buttons if action isn't available.
3c3a076 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357
Closes rero#1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 3, 2020
@zannkukai
circulation: hide buttons if action isn't available.
6b833aa 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357
Closes rero#1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 3, 2020
@zannkukai
circulation: hide buttons if action isn't available.
b43d054 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357
Closes rero#1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit added f: public ui Public interface, as opposed to the professional interface f: circulation Concerns the circulation interface or backend labels Nov 4, 2020
@iGormilhit iGormilhit added this to the v0.14.0 milestone Nov 4, 2020
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 4, 2020
@zannkukai
circulation: hide buttons if action isn't available.
41cce3b 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357
Closes rero#1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 4, 2020
@zannkukai
circulation: hide buttons if action isn't available.
0846e08 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357
Closes rero#1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 4, 2020
@zannkukai
circulation: hide buttons if action isn't available.
3dcbb24 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357
Closes rero#1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 4, 2020
@zannkukai
circulation: hide buttons if action isn't available.
48fd1d5 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357
Closes rero#1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 4, 2020
@zannkukai
circulation: hide buttons if action isn't available.
0fd4a1e 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357
Closes rero#1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 5, 2020
@zannkukai
circulation: hide buttons if action isn't available.
817e21f 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357
Closes rero#1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 5, 2020
@zannkukai
circulation: hide buttons if action isn't available.
371a541 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357
Closes rero#1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 5, 2020
@zannkukai
circulation: hide buttons if action isn't available.
2afc952 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes rero#1357
Closes rero#1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Nov 5, 2020
@zannkukai
circulation: hide buttons if action isn't available.
ac1d3c1 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes #1357
Closes #1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Nov 5, 2020
@zannkukai
circulation: hide buttons if action isn't available.
bee837b 
If the patron can't operate an action due to circulation restrictions
(patron blocked, patron type limits, ...), circulation buttons should be
disable. In the patron profile view, adds warning/error messages depending
of patron restrictions.

If the 'renew' button is disable, adds a tooltip to give user the
reasons why.

Closes #1357
Closes #1356

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit changed the title Show disabled "Renew" button in patron public account Display disabled "renew" button in patron account of the public interface Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend f: public ui Public interface, as opposed to the professional interface p-Low Low priority
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging a pull request may close this issue.

circulation: hide buttons if action isn't available. zannkukai/rero-ils
3 participants
@iGormilhit @pronguen @zannkukai