Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: fix double enter fire event #417

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

zannkukai
Copy link
Contributor

When using the main search box and validate it using 'enter' key, the
small 'input search box' from document result page was also fired and
cause a double search. The second request removes all filters from URL.

Closes rero/rero-ils#2130.

Co-authored-by: Renaud Michotte renaud.michotte@gmail.com

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

When using the main search box and validate it using 'enter' key, the
small 'input search box' from document result page was also fired and
cause a double search. The second request removes all filters from URL.

Closes rero/rero-ils#2130.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai self-assigned this Jul 8, 2021
@zannkukai zannkukai added this to the v.1.4.0 milestone Jul 8, 2021
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@sebdeleze sebdeleze merged commit e8518a1 into rero:dev Jul 9, 2021
@zannkukai zannkukai deleted the zan-fix-issue-2130 branch July 9, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default filter by logged in organisation in document search does not work anymore
4 participants