Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default filter by logged in organisation in document search does not work anymore #2130

Closed
pronguen opened this issue Jul 8, 2021 · 0 comments · Fixed by rero/ng-core#417
Closed

Default filter by logged in organisation in document search does not work anymore #2130

pronguen opened this issue Jul 8, 2021 · 0 comments · Fixed by rero/ng-core#417
Assignees
@zannkukai
Labels
bug (critical) Blocking issue, should be fixed ASAP bug Breaks something but is not blocking f: professional ui Professional interface p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.4.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Jul 8, 2021 •
edited by iGormilhit
Loading

Describe the bug

  • When searching documents, a default filter applies and limit the results to documents of my own organisation. It does not apply anymore (on v1.3.0, tested on ilspilotdev).
  • When no documents correspond to my query, I should see a button "Expand to all organisations". This button is not there anymore (on v1.3.0 and v1.4.0).

⚠️ This is prioritary because it prevents the cataloguing workflow.

To Reproduce

Case 1: Do a document search and see
Case 2: Do a document search that gives no results and see

Expected behavior

Case 1: filter is applied
Case 2: button is visible
@pronguen pronguen added f: professional ui Professional interface bug Breaks something but is not blocking p-High High priority (to be solved in the 2-3 next months) labels Jul 8, 2021
@iGormilhit iGormilhit added this to the v1.4.0 milestone Jul 8, 2021
@iGormilhit iGormilhit added the bug (critical) Blocking issue, should be fixed ASAP label Jul 8, 2021
zannkukai added a commit to zannkukai/ng-core that referenced this issue Jul 8, 2021
@zannkukai
search: fix double enter fire event
53c115b 
When using the main search box and validate it using 'enter' key, the
small 'input search box' from document result page was also fired and
cause a double search. The second request removes all filters from URL.

Closes rero/rero-ils#2130.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Jul 8, 2021
Merged
7 tasks
sebdeleze pushed a commit to rero/ng-core that referenced this issue Jul 9, 2021
@zannkukai
search: fix double enter fire event
e8518a1 
When using the main search box and validate it using 'enter' key, the
small 'input search box' from document result page was also fired and
cause a double search. The second request removes all filters from URL.

Closes rero/rero-ils#2130.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@pronguen pronguen mentioned this issue Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug (critical) Blocking issue, should be fixed ASAP bug Breaks something but is not blocking f: professional ui Professional interface p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

search: fix double enter fire event zannkukai/ng-core
3 participants
@iGormilhit @pronguen @zannkukai