Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: confirmation message when leaving #554

Merged
merged 1 commit into from
Jun 28, 2023
Merged

editor: confirmation message when leaving #554

merged 1 commit into from
Jun 28, 2023

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Jun 19, 2023 •
edited
Loading

A confirmation message is displayed if the user leaves the form without saving it.

@Garfield-fr Garfield-fr self-assigned this Jun 19, 2023
@Garfield-fr Garfield-fr force-pushed the zub-leaving-form branch 4 times, most recently from 6885943 to 7f51f69 Compare June 19, 2023 13:27
@Garfield-fr Garfield-fr force-pushed the zub-leaving-form branch 5 times, most recently from a3a78d2 to c118cd6 Compare June 20, 2023 07:02
@PascalRepond
Copy link
Contributor

PascalRepond commented Jun 20, 2023 •
edited
Loading

PO tests

  • REP: In all editors (except library editor), the confirmation message displays multiple times (as much as it has been used+1) before successfully leaving the page.
  • JD : [same as the previous problem ?] The use of the "Cancel" button should not display the confirmation message (example : when creating a new document).

@Garfield-fr Garfield-fr marked this pull request as draft June 20, 2023 15:45
@Garfield-fr Garfield-fr mentioned this pull request Jun 21, 2023
Merged
@Garfield-fr Garfield-fr marked this pull request as ready for review June 21, 2023 12:43
PascalRepond
PascalRepond approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@PascalRepond PascalRepond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly, great job!

@Garfield-fr
editor: confirmation message when leaving
b44a817 
A confirmation message is displayed if the user leaves
the form without saving it.

* Removes spinner on editor.
* Changes the visiblity of the property in the editor to allow
  abstracting the class.
* Closes rero/rero-ils#2104.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit 930b017 into rero:staging Jun 28, 2023
@Garfield-fr Garfield-fr deleted the zub-leaving-form branch September 18, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalRepond PascalRepond PascalRepond approved these changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma jma approved these changes

Assignees

@Garfield-fr Garfield-fr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirmation message when leaving a form without saving
4 participants
@Garfield-fr @PascalRepond @jma @zannkukai