Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: add can deactivate guard #1000

Merged
merged 1 commit into from
Jul 12, 2023
Merged

editor: add can deactivate guard #1000

merged 1 commit into from
Jul 12, 2023

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Jun 19, 2023 •
edited
Loading

A confirmation message is displayed if the user leaves the form without saving it.

Dependencies

@Garfield-fr Garfield-fr self-assigned this Jun 19, 2023
@github-actions github-actions bot added f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface labels Jun 19, 2023
@Garfield-fr Garfield-fr force-pushed the zub-leaving-form branch 3 times, most recently from b44cf2f to 888f25f Compare June 19, 2023 14:37
@github-actions github-actions bot added the f: acquisitions Related to the acquisition module label Jun 21, 2023
@Garfield-fr Garfield-fr changed the title library: add can deactivate guard editor: add can deactivate guard Jun 21, 2023
@Garfield-fr
editor: add can deactivate guard
ce27d95 
A confirmation message is displayed if the user leaves
the form without saving it.

* Fixes tests.
* Closes rero/rero-ils#2104.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: public ui Public interface, as opposed to the professional interface f: user management labels Jul 12, 2023
@Garfield-fr Garfield-fr merged commit 18603e3 into rero:staging Jul 12, 2023
@Garfield-fr Garfield-fr deleted the zub-leaving-form branch September 27, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zannkukai zannkukai zannkukai approved these changes

@jma jma jma approved these changes

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees

@Garfield-fr Garfield-fr

Labels
f: acquisitions Related to the acquisition module f: circulation Concerns the circulation interface or backend f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirmation message when leaving a form without saving
3 participants
@Garfield-fr @jma @zannkukai