Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fee action menu are displayed far away from "action" button #209

Closed
zannkukai opened this issue Mar 19, 2020 · 0 comments
Closed

Fee action menu are displayed far away from "action" button #209

zannkukai opened this issue Mar 19, 2020 · 0 comments
Labels
effort: minor Doesn't have to be a US

Comments

@zannkukai
Copy link
Contributor

When you expand a fee (to see details and history), then click on "action" button. The drop-down menu are displayed far below the button.

image

To Reproduce
Steps to reproduce the behavior:

  1. Logged as a librarian, in professional view, search about a patron with some pending fee
  2. Expand a fee to see detail+history (using caret on the left side)
  3. Click on "action" button
  4. See the drop-down menu far below action button

Expected behavior
The drop down menu should be display just below the action button. To see a correct behavior, jut collapse the fee and click again on "action" button

image
@zannkukai zannkukai added the effort: minor Doesn't have to be a US label Mar 19, 2020
@pronguen pronguen mentioned this issue Mar 30, 2020
Closed
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Mar 31, 2020
@zannkukai
transactions: bug fixing
904f2d4 
* Drop-down menu was displayed far away of the action button if a transaction was expanded.
  The menu is now displayed just below the transaction action button.
* As transaction event creation method susribed to `currentPatron$` observable, each time this
  observer emit content, a dummy transation event was created (with previously registered data event).
  This problem is now solved : the affected patron is now get from the parent transaction event.
* CSS buttons regarding UX chart

* Closes rero#209

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Mar 31, 2020
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Mar 31, 2020
@zannkukai
transactions: fix several issues
06b9736 
* Drop-down menu was displayed far away of the action button if a transaction was expanded.
  The menu is now displayed just below the transaction action button.
* As transaction event creation method susribed to `currentPatron$` observable, each time this
  observer emit content, a dummy transation event was created (with previously registered data event).
  This problem is now solved : the affected patron is now get from the parent transaction event.
* CSS buttons regarding UX chart

* Closes rero#209

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Mar 31, 2020
@zannkukai
transactions: fix fees UI issues
25e48b9 
* Fixes the position of the dropdown menu, now just below the transaction action button.
  It was misplaced far away of the action button if a transaction was expanded.
* Fixes the moment when flash messages occur. As transaction event creation method subscribed
  to `currentPatron$` observable, each time this observer emit content, a dummy transation
  event was created (with previously registered data event).
  This problem is now solved : the affected patron is now get from the parent transaction event.
* Adapts CSS buttons regarding UX charter.
* Closes rero#209

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@jma jma closed this as completed in 86a20f0 Apr 9, 2020
@iGormilhit iGormilhit mentioned this issue Jun 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: minor Doesn't have to be a US
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zannkukai