Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display manual overdue #1034

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix: display manual overdue #1034

merged 1 commit into from
Sep 4, 2023

Conversation

Garfield-fr
Copy link
Contributor

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@Garfield-fr Garfield-fr self-assigned this Aug 29, 2023
@github-actions github-actions bot added f: professional ui Professional interface f: circulation Concerns the circulation interface or backend f: user management labels Aug 29, 2023
jma
jma approved these changes Aug 29, 2023
View reviewed changes
...ctions/patron-transaction/overdue-transaction-detail/overdue-transaction-detail.component.ts Outdated
@@ -29,7 +46,7 @@ export class OverdueTransactionDetailComponent implements OnInit {
this._recordService.getRecord('loans', this.transaction.loan.pid).pipe(
map(data => data.metadata),
mergeMap( data => this._recordService.getRecord('items', data.item_pid.value)),
map(data => new Item(data.metadata))
map(data => { console.log(data); return new Item(data.metadata); })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can safely remove this.

@Garfield-fr
fix: display manual overdue
e723657 
* closes rero/rero-ils#3438.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@PascalRepond PascalRepond merged commit 967bbe9 into rero:staging Sep 4, 2023
@Garfield-fr Garfield-fr deleted the zub-overdue-fix branch October 10, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@zannkukai zannkukai zannkukai approved these changes

@PascalRepond PascalRepond PascalRepond approved these changes

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees

@Garfield-fr Garfield-fr

Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manual fees UI: problems with manual fees of type overdue
4 participants
@Garfield-fr @jma @zannkukai @PascalRepond