Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual fees UI: problems with manual fees of type overdue #3438

Closed
PascalRepond opened this issue Aug 22, 2023 · 0 comments · Fixed by rero/rero-ils-ui#1034
Closed

Manual fees UI: problems with manual fees of type overdue #3438

PascalRepond opened this issue Aug 22, 2023 · 0 comments · Fixed by rero/rero-ils-ui#1034
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: circulation Concerns the circulation interface or backend f: professional ui Professional interface

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Aug 22, 2023

Bug description:

Adding fees of type overdue manually from the circulation interface creates some display problems.

Remarks

Probably the UI looks for an item to display that is linked to the overdue fee but cannot find it since the fee is manual and has no link to an item. Either adapt the UI to be more robust or just change this type value to e.g. manual_overdue to be unamiguous.

Expected behavior:

  • A manual fee of type overdue should behave like other manual fees and not create UI problems.

Steps to Reproduce:

  1. Go to a patron profile
  2. Click on "Add a fee"
  3. Add a fee of type "overdue" with a note
  4. See problems

Screenshots

Capture1
Capture2

Version:

v1.18.0

@PascalRepond PascalRepond added f: circulation Concerns the circulation interface or backend bug Breaks something but is not blocking client request Issue reported by production libraries labels Aug 22, 2023
@PascalRepond PascalRepond added the f: professional ui Professional interface label Aug 22, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Aug 22, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Aug 29, 2023
* closes rero/rero-ils#3438.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr moved this from Product Backlog to Ready to test in RERO ILS issues Aug 29, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Aug 30, 2023
* closes rero/rero-ils#3438.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Aug 30, 2023
* closes rero/rero-ils#3438.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Aug 30, 2023
* closes rero/rero-ils#3438.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Aug 31, 2023
PascalRepond pushed a commit to rero/rero-ils-ui that referenced this issue Sep 4, 2023
* closes rero/rero-ils#3438.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@github-project-automation github-project-automation bot moved this from In testing to Done in RERO ILS issues Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: circulation Concerns the circulation interface or backend f: professional ui Professional interface
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant