Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circulation: add pickup name on checkin #1036

Merged
merged 1 commit into from
Oct 3, 2023
Merged

circulation: add pickup name on checkin #1036

merged 1 commit into from
Oct 3, 2023

Conversation

Garfield-fr
Copy link
Contributor

Dependencies

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@Garfield-fr Garfield-fr self-assigned this Aug 31, 2023
@github-actions github-actions bot added f: professional ui Professional interface f: circulation Concerns the circulation interface or backend labels Aug 31, 2023
@jma jma removed their request for review September 27, 2023 09:49
@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Sep 28, 2023 •
edited
Loading

  • On the checkin view, the patron link is not correct. Ex https://ilsdev.test.rero.ch/professional/circulation/patron/k/loan (not linked to the pr??)
  • Error when an item is in transit and is checked in. ERROR TypeError: Cannot read properties of undefined (reading 'pickup_name')
    1/ Checkin view (or request view). Pickup location not displayed when the item is checked in (or validated) at the owning location --> item in transit.
    Step: Request an item of library A to pickup at library B. Validate the item in the request view of library A.
    image
    2/ Checkin view. Missing information (patron name...) when the item is checked in at the pickup location.
    Step: Checkin the item at library B.
    image

@Garfield-fr
circulation: add pickup name on checkin
8bd4713 
* Adds location pickup name when the loan is in at_desk status
  during the checkin.
* Closes rero/rero-ils#3433.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit 6514492 into rero:staging Oct 3, 2023
3 checks passed
@Garfield-fr Garfield-fr deleted the zub-pickup-name branch October 10, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalRepond PascalRepond PascalRepond approved these changes

@zannkukai zannkukai zannkukai approved these changes

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees

@Garfield-fr Garfield-fr

Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circulation UI: display pickup location for at_desk check-in
4 participants
@Garfield-fr @ManaDeweerdt @zannkukai @PascalRepond